RF: Blind attempt to relay status() performance boost possibility on to save() #3712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mih
changed the title
According to my current logic and assessment, the status() run done in top-level save() does not need to inspect filetypes. The tests will show if that is true. If true, performance gains of the same magnitude as shown in datalad#3701 for status() also become available for save().
python -m nose -s -v datalad.support.tests.test_annexrepo:test_files_split Before: 249.66s user 21.72s system 139% cpu 3:14.46 total After: 199.29s user 20.01s system 129% cpu 2:48.96 total
|
Hmm, strange timeouts on travis. I cannot reproduce that locally and travis no longer tells which particular test it is happening in. |
Codecov Report
@@ Coverage Diff @@
## master #3712 +/- ##
=========================================
- Coverage 82.77% 80.5% -2.28%
=========================================
Files 273 273
Lines 35918 35918
=========================================
- Hits 29732 28915 -817
- Misses 6186 7003 +817
Continue to review full report at Codecov.
|
|
OK, whatever it would break, our tests don't see it. Neither does my imagination. So let's do it and wait for the eventual bug report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my current logic and assessment, the
status()run done intop-level
save()does not need to inspect filetypes. The tests will showif that is true.
If true, performance gains of the same magnitude as shown in
#3701 for
status()also becomeavailable for
save().