Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: path_is_under() could not handle win paths from different drives #3728

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

mih
Copy link
Member

@mih mih commented Sep 27, 2019

@mih mih merged commit cc7b2e2 into datalad:master Sep 27, 2019
@mih mih deleted the bf-noncdrive branch September 27, 2019 10:26
@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #3728 into master will increase coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3728      +/-   ##
==========================================
+ Coverage   82.79%   82.81%   +0.01%     
==========================================
  Files         273      273              
  Lines       35812    35817       +5     
==========================================
+ Hits        29652    29663      +11     
+ Misses       6160     6154       -6
Impacted Files Coverage Δ
datalad/interface/utils.py 88.23% <80%> (-0.17%) ⬇️
datalad/support/annexrepo.py 61.1% <0%> (-2.39%) ⬇️
datalad/distribution/remove.py 71.65% <0%> (-1.58%) ⬇️
datalad/core/local/run.py 94.71% <0%> (-1.45%) ⬇️
datalad/support/network.py 81.48% <0%> (-1.16%) ⬇️
datalad/interface/results.py 94.26% <0%> (-0.82%) ⬇️
datalad/tests/test_utils.py 96.1% <0%> (+0.26%) ⬆️
datalad/tests/utils.py 90.39% <0%> (+0.36%) ⬆️
datalad/support/tests/test_annexrepo.py 96.31% <0%> (+0.4%) ⬆️
datalad/tests/test_log.py 99% <0%> (+0.99%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4906c20...df67899. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

path_is_under() cannot handle abspaths from different windows drives
1 participant