Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF(TST,workaround): do not use ; in the test archive filenames #3770

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Oct 11, 2019

Python issue: https://bugs.python.org/issue38449

Closes #3769

TODO:

  • make datalad.customremotes.tests.test_archives.test_basic_scenario use that tricky name variable

Copy link
Contributor

@kyleam kyleam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely analyzed. Thanks.

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #3770 into 0.11.x will increase coverage by 0.15%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.11.x    #3770      +/-   ##
==========================================
+ Coverage   81.07%   81.23%   +0.15%     
==========================================
  Files         256      256              
  Lines       33944    33949       +5     
==========================================
+ Hits        27520    27577      +57     
+ Misses       6424     6372      -52
Impacted Files Coverage Δ
datalad/customremotes/tests/test_archives.py 90.13% <100%> (-0.13%) ⬇️
datalad/tests/test_archives.py 90.57% <42.85%> (-2.56%) ⬇️
datalad/utils.py 65.19% <0%> (+0.31%) ⬆️
datalad/support/annexrepo.py 57.75% <0%> (+0.5%) ⬆️
datalad/interface/run.py 72.13% <0%> (+1.49%) ⬆️
datalad/interface/unlock.py 77.77% <0%> (+13.58%) ⬆️
datalad/interface/run_procedure.py 88.19% <0%> (+19.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953673b...73cc313. Read the comment docs.

@yarikoptic
Copy link
Member Author

Nicely analyzed. Thanks.

and thanks for the bisection!

@yarikoptic
Copy link
Member Author

if no objections/failures -- it will get closed by me pushing the 0.11.8 release which would include this

@yarikoptic yarikoptic merged commit 73cc313 into datalad:0.11.x Oct 14, 2019
yarikoptic added a commit that referenced this pull request Oct 14, 2019
0.11.8 (Oct 11, 2019) -- annex-we-are-catching-up

Fixes

- Our internal command runner failed to capture output in some cases.
  ([#3656][])
- Workaround in the tests around python in cPython >= 3.7.5 ';' in
  the filename confusing mimetypes ([#3769][]) ([#3770][])

Enhancements and new features

- Prepared for upstream changes in git-annex, including support for
  the latest git-annex
  - 7.20190912 auto-upgrades v5 repositories to v7.  ([#3648][]) ([#3682][])
  - 7.20191009 fixed treatment of (larger/smaller)than in .gitattributes ([#3765][])

- The `cfg_text2git` procedure, as well the `--text-no-annex` option
  of [create][], now configure .gitattributes so that empty files are
  stored in git rather than annex.  ([#3667][])

* tag '0.11.8': (27 commits)
  DOC: add CHANGELOG entry about mimetypes workaround, and regenerate changelog.rst
  RF: reuse fn*obscure* variables from test_archives for testing archives custom remote
  BF(TST,workaround): do not use ; in the test archive filenames
  Finalize changelog and boost version
  DOC: Adjust CHANGELOG for the fix of test
  RF(TST): use 'willgetshort' name to correctly reflect file behavior
  BF(TST): reflect the fact that since 7.20191009 file would jump from annex to git based on current size
  CHANGELOG.md: Add entry for gh-3667
  CHANGELOG.md: First batch for 0.11.8
  RF: simplify the expression for largefiles based on size
  ENH: exit with dedicated 99 exit code if installed annex is newer than -devel
  TST: known_failure_v6_or_later: Consider whether v5 is supported by git-annex
  BF(v7): gitrepo: Avoid adding files to annex
  BF: 3rdparty_analysis_workflow: Make example compatible with v6+
  ENH: annexrepo: Give more informative assertion error
  BF: annexrepo: Skip empty lines when expecting one output line
  TST: create: Adjust --text-no-annex test for aa6b8dc
  ENH: add file size rule to --text-no-annex
  TST: basic test for empty files in text2git ds
  ENH: exclude empty files from being annexed after text2git
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants