Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dataset('^') work with CWD not being a dataset root #3772

Merged
merged 3 commits into from Oct 11, 2019

Conversation

mih
Copy link
Member

@mih mih commented Oct 11, 2019

Fixes gh-3709. Test inside.

mih added 3 commits Oct 11, 2019
Dataset.get_super_dataset() assumes that the Dataset instance is
pointing to an actual dataset root, not just somewhere inside.

Fixes dataladgh-3709
kyleam
kyleam approved these changes Oct 11, 2019
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #3772 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3772      +/-   ##
==========================================
+ Coverage   80.67%   80.68%   +0.01%     
==========================================
  Files         273      273              
  Lines       35962    36530     +568     
==========================================
+ Hits        29011    29473     +462     
- Misses       6951     7057     +106
Impacted Files Coverage Δ
datalad/distribution/tests/test_dataset.py 99.68% <100%> (ø) ⬆️
datalad/distribution/dataset.py 93.28% <100%> (+1.06%) ⬆️
datalad/support/archives.py 61.32% <0%> (-22.66%) ⬇️
datalad/support/cookies.py 59.7% <0%> (-16.42%) ⬇️
datalad/support/tests/test_cookies.py 85.71% <0%> (-14.29%) ⬇️
datalad/support/locking.py 95.12% <0%> (-2.44%) ⬇️
datalad/local/subdatasets.py 78.67% <0%> (-2.36%) ⬇️
datalad/support/tests/test_annexrepo.py 96.07% <0%> (-0.32%) ⬇️
datalad/support/gitrepo.py 85.21% <0%> (+1.03%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ad8d02...719dfa1. Read the comment docs.

@kyleam kyleam merged commit 719dfa1 into datalad:master Oct 11, 2019
16 checks passed
kyleam added a commit that referenced this issue Oct 11, 2019
@mih mih deleted the bf-3709 branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants