-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BF: install
relpath semantics
#3777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question
datalad/distribution/install.py
Outdated
@@ -323,7 +323,7 @@ def __call__( | |||
# yoh: path should be a local path, and mapping note within | |||
# SSHRI about mapping localhost:path to path is kinda | |||
# a peculiar use-case IMHO | |||
path = resolve_path(path_ri.localpath, dataset) | |||
path = rev_resolve_path(path_ri.localpath, dataset) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is what confuses me - why then this new function should not just replace the old one? When should I use old over overwatch if the new one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It always has to go. I just don't have the juice to do it all at once: #3778
Codecov Report
@@ Coverage Diff @@
## master #3777 +/- ##
========================================
- Coverage 71.19% 69.8% -1.4%
========================================
Files 273 273
Lines 35973 35968 -5
========================================
- Hits 25610 25106 -504
- Misses 10363 10862 +499
Continue to review full report at Codecov.
|
Fixes #3469