Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: install relpath semantics #3777

Merged
merged 3 commits into from Oct 14, 2019
Merged

BF: install relpath semantics #3777

merged 3 commits into from Oct 14, 2019

Conversation

mih
Copy link
Member

@mih mih commented Oct 13, 2019

Fixes #3469

Copy link
Member

@yarikoptic yarikoptic left a comment

A question

@@ -323,7 +323,7 @@ def __call__(
# yoh: path should be a local path, and mapping note within
# SSHRI about mapping localhost:path to path is kinda
# a peculiar use-case IMHO
path = resolve_path(path_ri.localpath, dataset)
path = rev_resolve_path(path_ri.localpath, dataset)
Copy link
Member

@yarikoptic yarikoptic Oct 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what confuses me - why then this new function should not just replace the old one? When should I use old over overwatch if the new one?

Copy link
Member Author

@mih mih Oct 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It always has to go. I just don't have the juice to do it all at once: #3778

@codecov
Copy link

@codecov codecov bot commented Oct 14, 2019

Codecov Report

Merging #3777 into master will decrease coverage by 1.39%.
The diff coverage is 87.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3777     +/-   ##
========================================
- Coverage   71.19%   69.8%   -1.4%     
========================================
  Files         273     273             
  Lines       35973   35968      -5     
========================================
- Hits        25610   25106    -504     
- Misses      10363   10862    +499
Impacted Files Coverage Δ
datalad/distribution/tests/test_install.py 99.6% <100%> (ø) ⬆️
datalad/distribution/install.py 46.6% <50%> (ø) ⬆️
...ad/metadata/extractors/frictionless_datapackage.py 27.08% <0%> (-68.75%) ⬇️
datalad/metadata/extractors/xmp.py 24.07% <0%> (-68.52%) ⬇️
datalad/metadata/extractors/datalad_rfc822.py 30.9% <0%> (-67.28%) ⬇️
datalad/metadata/extractors/exif.py 34.37% <0%> (-62.5%) ⬇️
datalad/metadata/extractors/audio.py 37.14% <0%> (-60%) ⬇️
datalad/metadata/extractors/datacite.py 31.25% <0%> (-58.34%) ⬇️
datalad/metadata/extractors/annex.py 35.48% <0%> (-58.07%) ⬇️
datalad/support/status.py 33.33% <0%> (-57.58%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bb7b70...aa56aa1. Read the comment docs.

@mih mih merged commit 859f780 into datalad:master Oct 14, 2019
13 of 14 checks passed
@mih mih deleted the bf-3469 branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants