Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light RF of clone() #3780

Merged
merged 8 commits into from
Oct 14, 2019
Merged

Light RF of clone() #3780

merged 8 commits into from
Oct 14, 2019

Conversation

mih
Copy link
Member

@mih mih commented Oct 14, 2019

  • use correct helper for current relpath semantics
  • move internal helpers into clone.py (also move tests)
  • apply current formatting patterns

Use `rev_resolve_path()` to get current relpath semantics (dataladgh-3778)
Not used elsewhere, not actually useful in a generic context. Also
move the associated tests to improve modularity.
This anticipates errors with misspecified paths like

```
OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: 'd:\\a\\datalad\\datalad\\__testhome__\\ssh:\\mars:Zoidberg'
```

A test is already in place (fails without this on Windows).
@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #3780 into master will decrease coverage by 0.04%.
The diff coverage is 92.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3780      +/-   ##
==========================================
- Coverage   80.78%   80.74%   -0.05%     
==========================================
  Files         273      273              
  Lines       35976    35933      -43     
==========================================
- Hits        29065    29015      -50     
- Misses       6911     6918       +7
Impacted Files Coverage Δ
datalad/distribution/tests/test_install.py 99.79% <ø> (-0.01%) ⬇️
datalad/distribution/utils.py 89.74% <ø> (+2.11%) ⬆️
datalad/distribution/tests/test_clone.py 100% <100%> (ø) ⬆️
datalad/distribution/clone.py 90.85% <90.24%> (-3.32%) ⬇️
datalad/downloaders/tests/test_http.py 58.08% <0%> (-2.21%) ⬇️
datalad/log.py 65.86% <0%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 859f780...9a979d8. Read the comment docs.

@mih
Copy link
Member Author

mih commented Oct 14, 2019

Thx @kyleam !

@mih mih merged commit f3dc732 into datalad:master Oct 14, 2019
@mih mih deleted the rf-clone branch October 14, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants