Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: rev_resolve_path() -> resolve_path() #3797

Merged
merged 2 commits into from Oct 19, 2019
Merged

Conversation

mih
Copy link
Member

@mih mih commented Oct 18, 2019

Fixes gh-3778

Old function is now an internal helper of annotate_paths(), and the tests have moved their as well. A more extensive test suite for the "new" function was already in place.

@codecov
Copy link

@codecov codecov bot commented Oct 18, 2019

Codecov Report

Merging #3797 into master will decrease coverage by 0.29%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3797     +/-   ##
=========================================
- Coverage   80.68%   80.39%   -0.3%     
=========================================
  Files         273      273             
  Lines       35917    36072    +155     
=========================================
+ Hits        28981    28999     +18     
- Misses       6936     7073    +137
Impacted Files Coverage Δ
datalad/distributed/create_sibling_gitlab.py 18.83% <0%> (ø) ⬆️
datalad/distribution/clone.py 90.85% <100%> (ø) ⬆️
datalad/local/subdatasets.py 81.19% <100%> (ø) ⬆️
datalad/interface/tests/test_annotate_paths.py 100% <100%> (ø) ⬆️
datalad/core/local/diff.py 96.15% <100%> (ø) ⬆️
datalad/core/local/status.py 96.03% <100%> (ø) ⬆️
datalad/core/local/create.py 96.21% <100%> (ø) ⬆️
datalad/interface/unlock.py 98.57% <100%> (ø) ⬆️
datalad/distribution/dataset.py 93.11% <100%> (-0.18%) ⬇️
datalad/interface/base.py 90.06% <100%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7947b...4f68b47. Read the comment docs.

@mih mih requested a review from kyleam Oct 18, 2019
kyleam
kyleam approved these changes Oct 19, 2019
@kyleam kyleam merged commit 4f68b47 into datalad:master Oct 19, 2019
16 checks passed
@mih mih deleted the rf-resolvepath branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants