Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Adjust version extraction from manpage for proper test #3798

Merged
merged 1 commit into from Oct 18, 2019

Conversation

mih
Copy link
Member

@mih mih commented Oct 18, 2019

Due to an earlier change the version is now located in a different position in the header.

Fixes gh-3151

Due to an earlier change the version is now located in a different
position in the header.

Fixes dataladgh-3151
@mih mih added this to to-be-categorized in Release 0.12 via automation Oct 18, 2019
@codecov
Copy link

@codecov codecov bot commented Oct 18, 2019

Codecov Report

Merging #3798 into master will increase coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3798     +/-   ##
=========================================
+ Coverage   80.68%   80.78%   +0.1%     
=========================================
  Files         273      273             
  Lines       35931    35931             
=========================================
+ Hits        28990    29027     +37     
+ Misses       6941     6904     -37
Impacted Files Coverage Δ
datalad/cmdline/helpers.py 60.48% <0%> (ø) ⬆️
datalad/utils.py 63.65% <0%> (-0.53%) ⬇️
datalad/support/annexrepo.py 58.34% <0%> (+0.08%) ⬆️
datalad/support/network.py 81.71% <0%> (+0.23%) ⬆️
datalad/tests/test_log.py 99.01% <0%> (+0.98%) ⬆️
datalad/downloaders/tests/test_http.py 61.51% <0%> (+1.22%) ⬆️
datalad/log.py 65.86% <0%> (+16.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a649363...ff965a9. Read the comment docs.

@mih
Copy link
Member Author

@mih mih commented Oct 18, 2019

This is objectively correct, merging.

@mih mih merged commit e7305d3 into datalad:master Oct 18, 2019
15 of 16 checks passed
@mih mih deleted the bf-3151 branch Oct 18, 2019
@mih mih moved this from to-be-categorized to Blocker in Release 0.12 Oct 19, 2019
@mih mih moved this from Blocker to done in Release 0.12 Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 0.12
  
done
Development

Successfully merging this pull request may close these issues.

1 participant