Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Detect a detached HEAD that prevents publication of HEAD #3804

Merged
merged 2 commits into from Oct 20, 2019

Conversation

mih
Copy link
Member

@mih mih commented Oct 18, 2019

Yield 'impossible' result in this case.

Fixes gh-1811

Now looks like this:

mih@meiner /tmp/clone (git)-[9995911...] % datalad publish --to origin
publish(impossible): . (dataset) [Cannot determine remote branch name from HEAD]

@mih mih added this to to-be-categorized in Release 0.12 via automation Oct 19, 2019
@mih mih moved this from to-be-categorized to Blocker in Release 0.12 Oct 19, 2019
@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #3804 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3804      +/-   ##
==========================================
- Coverage   80.79%   80.77%   -0.02%     
==========================================
  Files         273      273              
  Lines       35978    35996      +18     
==========================================
+ Hits        29067    29076       +9     
- Misses       6911     6920       +9
Impacted Files Coverage Δ
datalad/distribution/publish.py 51.74% <100%> (+1.03%) ⬆️
datalad/distribution/tests/test_publish.py 100% <100%> (ø) ⬆️
datalad/downloaders/tests/test_http.py 58.08% <0%> (-2.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d48a52d...e8593b5. Read the comment docs.

@mih
Copy link
Member Author

mih commented Oct 20, 2019

Thx @yarikoptic

@mih mih merged commit 2979bec into datalad:master Oct 20, 2019
16 checks passed
Release 0.12 automation moved this from Blocker to done Oct 20, 2019
@mih mih deleted the bf-gh1811 branch Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 0.12
  
done
Development

Successfully merging this pull request may close these issues.

2 participants