BF: Move Git identity check into ConfigManager and make more valid #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleam
approved these changes
Oct 19, 2019
| "DataLad. Set both 'user.name' and 'user.email' " | ||
| "configuration variables." | ||
| ) | ||
| ConfigManager._checked_git_identity = True |
There was a problem hiding this comment.
s/ConfigManager/self/ feels a bit more natural to me, but it's of course fine as is.
There was a problem hiding this comment.
True, but I my personal preference is pointing the other way ;-)
|
Didnt realize we have a test run that sets identity variables. Will fix up |
Codecov Report
@@ Coverage Diff @@
## master #3807 +/- ##
==========================================
+ Coverage 70.31% 80.61% +10.3%
==========================================
Files 273 273
Lines 35954 35966 +12
==========================================
+ Hits 25280 28993 +3713
+ Misses 10674 6973 -3701
Continue to review full report at Codecov.
|
Also considers standard environment variables now. Importantly, the check is no down without dedicated extra calls to git config, saving two calls (that were pretty much always performed). Fixes dataladgh-3750
|
Thx @kyleam for the review. All good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Also considers standard environment variables now.
Importantly, the check is no down without dedicated extra calls to git
config, saving two calls (that were pretty much always performed).
Fixes gh-3750