Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Remove unused and untested GitRepo.get_file_content() #3812

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

mih
Copy link
Member

@mih mih commented Oct 20, 2019

This sits on top of gh-3811

@mih mih mentioned this pull request Oct 20, 2019
15 tasks
@mih mih added this to to-be-categorized in Release 0.12 via automation Oct 20, 2019
@mih mih moved this from to-be-categorized to nice-to-have in Release 0.12 Oct 20, 2019
@codecov
Copy link

codecov bot commented Oct 20, 2019

Codecov Report

Merging #3812 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3812      +/-   ##
==========================================
- Coverage   80.74%   80.74%   -0.01%     
==========================================
  Files         273      273              
  Lines       35944    35918      -26     
==========================================
- Hits        29024    29001      -23     
+ Misses       6920     6917       -3
Impacted Files Coverage Δ
datalad/support/gitrepo.py 83.79% <ø> (+0.61%) ⬆️
datalad/support/annexrepo.py 56.98% <ø> (ø) ⬆️
datalad/support/tests/test_gitrepo.py 99.88% <ø> (-0.01%) ⬇️
datalad/distribution/get.py 80% <100%> (-0.96%) ⬇️
datalad/downloaders/tests/test_http.py 58.08% <0%> (-2.21%) ⬇️
datalad/utils.py 64.07% <0%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f37ebe...1bc3d3b. Read the comment docs.

@mih
Copy link
Member Author

mih commented Oct 21, 2019

OK, let's get rid of it. I cannot see any reason to keep it in.

@mih mih merged commit 3f1652d into datalad:master Oct 21, 2019
Release 0.12 automation moved this from nice-to-have to done Oct 21, 2019
@mih mih deleted the rf-getfilecontent branch October 21, 2019 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 0.12
  
done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant