Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Move tracking branch update functionality into GitRepo.update_submodule() #3831

Merged
merged 2 commits into from Oct 30, 2019

Conversation

mih
Copy link
Member

@mih mih commented Oct 24, 2019

This implements a long-standing TODO. It was originally part of #3828 but I moved it out, because it may need more work.

datalad/support/gitrepo.py Outdated Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented Oct 25, 2019

Codecov Report

Merging #3831 into master will increase coverage by 0.02%.
The diff coverage is 91.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3831      +/-   ##
==========================================
+ Coverage   80.75%   80.78%   +0.02%     
==========================================
  Files         273      273              
  Lines       35925    35995      +70     
==========================================
+ Hits        29012    29079      +67     
- Misses       6913     6916       +3
Impacted Files Coverage Δ
datalad/distribution/get.py 85.36% <ø> (+3.63%) ⬆️
datalad/support/tests/test_gitrepo.py 99.89% <100%> (ø) ⬆️
datalad/support/gitrepo.py 83.46% <80.95%> (-0.05%) ⬇️
datalad/downloaders/tests/test_http.py 58.08% <0%> (-2.21%) ⬇️
datalad/distribution/install.py 97.75% <0%> (+0.02%) ⬆️
datalad/core/local/create.py 96.24% <0%> (+0.02%) ⬆️
datalad/core/local/run.py 92.24% <0%> (+0.03%) ⬆️
datalad/core/local/status.py 96.07% <0%> (+0.03%) ⬆️
datalad/core/local/save.py 86.84% <0%> (+0.17%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 236204c...fb472ac. Read the comment docs.

@mih mih force-pushed the rf-updatesubmodule branch 2 times, most recently from 3d749e0 to 1f70a02 Compare Oct 29, 2019
@mih
Copy link
Member Author

@mih mih commented Oct 29, 2019

This is ready, I think.

@bpoldrack
Copy link
Member

@bpoldrack bpoldrack commented Oct 29, 2019

Looks right to me.

kyleam
kyleam approved these changes Oct 29, 2019
Copy link
Contributor

@kyleam kyleam left a comment

The code movement looks right to me too. I've pushed a test (which hopefully doesn't break this PR)

@mih
Copy link
Member Author

@mih mih commented Oct 30, 2019

Thanks for the test @kyleam!

@mih mih merged commit 1bec3aa into datalad:master Oct 30, 2019
16 checks passed
@mih mih deleted the rf-updatesubmodule branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants