BF/ENH: pass through already versioned s3:// urls while requesting them being versioned #3842
Conversation
left the other case as NotImplemented although it is not clear yet why code below could not just be used
Codecov Report
@@ Coverage Diff @@
## 0.11.x #3842 +/- ##
===========================================
- Coverage 77.17% 56.41% -20.76%
===========================================
Files 256 94 -162
Lines 33962 15119 -18843
===========================================
- Hits 26210 8530 -17680
+ Misses 7752 6589 -1163
Continue to review full report at Codecov.
|
|
The appveyor failure is an unrelated codecov connection failure. |
| if url_rec.query and 'versionId=' in url_rec.query: | ||
| was_versioned = True | ||
| all_versions.append(url) |
There was a problem hiding this comment.
Taking another look, shouldn't this part be done for all URLs, not just ones with an s3 scheme?
There was a problem hiding this comment.
Good point! Indeed it should for all aws URLs. I will refactor tomorrow unless someone beats me to it by then
There was a problem hiding this comment.
Oh, but it does point to inadequacy in comparison to http URLs (in the long run since s3 URLs support officially not implemented) when we request all versions?
Something to eat least add a comment about I think
There was a problem hiding this comment.
but it does point to inadequacy in comparison to http URLs (in the long run since s3 URLs support officially not implemented) when we request all versions?
I'm not seeing what the inadequacy is, so I'll leave that comment to you.
There was a problem hiding this comment.
if I understood 58f3d92 correctly, if I provide a versioned http url, and request all versions -- it will get decomposed and I get all versions. With current quick workaround I did, if I provide versioned s3 url, and request all versions -- only that version would be returned.
There was a problem hiding this comment.
OK, so you're talking about the same thing that you comment on in the first commit of this PR: the PR doesn't properly retrieve versions for s3:// urls, but we'll pass through a s3:// that already has a version tag. Given that you said the initial question in this thread "pointed to inadequacy", I assumed you must have been referring to something else.
Closes #3840
Todos