MNT: Drop external mock dependency #3860
Conversation
We've dropped Python 2 support, and since Python 3.3 mock is included in the standard library.
kyleam
added
the
do not merge
|
Marked as "do not merge". The released versions of the crawler and container extensions implicitly expect the external |
mock is assumed to be present because it's a dependency of datalad. However the master branch of datalad no longer supports Python 2, so it's free to drop its dependency on the external mock library in favor of unittest.mock, which comes with the standard library as of Python 3.3. Explicitly specify mock as a requirement for the tests. Re: datalad/datalad#3860
Codecov Report
@@ Coverage Diff @@
## master #3860 +/- ##
==========================================
+ Coverage 80.7% 80.77% +0.07%
==========================================
Files 273 273
Lines 36012 36012
==========================================
+ Hits 29063 29090 +27
+ Misses 6949 6922 -27
Continue to review full report at Codecov.
|
We assume these are present because they're dependencies of datalad. However the master branch of datalad no longer supports Python 2, so it's free to drop its dependency on the external mock library in favor of unittest.mock, which comes with the standard library as of Python 3.3. The floor for nose matches the one in datalad's setup.py. Re: datalad/datalad#3860
We assume these are present because they're dependencies of datalad. However the master branch of datalad no longer supports Python 2, so it's free to drop its dependency on the external mock library in favor of unittest.mock, which comes with the standard library as of Python 3.3. The floor for nose matches the one in datalad's setup.py. Re: datalad/datalad#3860
|
I pushed 0.4.4 of datalad-crawler, so it should be all set. restarted the checks (couldn't figure out how to restart only the one for the crawler) |
datalad-crawler still supports python 2, so it depends on the external mock library for its tests. Install with "[devel]" so that we install mock.
Thanks. It looks like the build still failed because the devel dependencies for mock weren't being pulled down. I've adjusted .github/workflows/test_extensions.yml to (hopefully) do so, but feel free to tweak if there's a cleaner way to accomplish this. |
kyleam
removed
the
do not merge
I guess in the long run we just need to obey some convention, e.g. to install |
We've dropped Python 2 support, and since Python 3.3 mock is included
in the standard library.