Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Remove obsolete add_sibling module #3871

Merged
merged 1 commit into from Nov 19, 2019

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented Nov 15, 2019

368b59f (Merge pull request #1579 from mih/rf-siblings, 2017-06-15)
pruned add_sibling.py down to a single function, _check_deps(), which
was left because it still had a caller. That caller was dropped in
d483e54 (RF: new-style create-sibling, 2017-06-10).

368b59f (Merge pull request datalad#1579 from mih/rf-siblings, 2017-06-15)
pruned add_sibling.py down to a single function, _check_deps(), which
was left because it still had a caller.  That caller was dropped in
d483e54 (RF: new-style `create-sibling`, 2017-06-10).
@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #3871 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3871      +/-   ##
==========================================
+ Coverage   80.74%   80.76%   +0.02%     
==========================================
  Files         273      272       -1     
  Lines       36017    36009       -8     
==========================================
+ Hits        29082    29083       +1     
+ Misses       6935     6926       -9
Impacted Files Coverage Δ
datalad/distribution/create_sibling.py 26.18% <ø> (-0.24%) ⬇️
datalad/log.py 64.9% <0%> (-0.97%) ⬇️
datalad/support/annexrepo.py 56.82% <0%> (-0.09%) ⬇️
datalad/downloaders/tests/test_http.py 60.29% <0%> (+2.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7258bdd...f71452c. Read the comment docs.

@kyleam
Copy link
Contributor Author

kyleam commented Nov 19, 2019

Seems clear-cut. Merging.

@kyleam kyleam merged commit f71452c into datalad:master Nov 19, 2019
17 checks passed
@kyleam kyleam deleted the remove-add-sibling branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant