BF: rerun --report: Restore diff value to original form #3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we started storing the diff() results in 168c49e (NF: rerun: Add --report, 2018-05-22), the results didn't include unchanged files. However, the new diff() command---merged with 50beb3b (RF: Aborb rev-diff, 2019-04-30)---returns an entry for all files in the working tree, with unchanged files having a state of "clean". Filter these out to restore the original behavior and avoid dumping a large amount of uninteresting information to `rerun --report` callers.
|
AppVeyor failure is the familiar hanging of test_autoenabled_remote_msg. This restores behavior from 0.11.x, so I'm hoping it's uncontroversial. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When we started storing the diff() results in 168c49e (NF: rerun:
Add --report, 2018-05-22), the results didn't include unchanged files.
However, the new diff() command---merged with 50beb3b (RF: Aborb
rev-diff, 2019-04-30)---returns an entry for all files in the working
tree, with unchanged files having a state of "clean".
Filter these out to restore the original behavior and avoid dumping a
large amount of uninteresting information to
rerun --reportcallers.