Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: rerun --report: Restore diff value to original form #3873

Merged
merged 1 commit into from Nov 19, 2019

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented Nov 15, 2019

When we started storing the diff() results in 168c49e (NF: rerun:
Add --report, 2018-05-22), the results didn't include unchanged files.
However, the new diff() command---merged with 50beb3b (RF: Aborb
rev-diff, 2019-04-30)---returns an entry for all files in the working
tree, with unchanged files having a state of "clean".

Filter these out to restore the original behavior and avoid dumping a
large amount of uninteresting information to rerun --report callers.

When we started storing the diff() results in 168c49e (NF: rerun:
Add --report, 2018-05-22), the results didn't include unchanged files.
However, the new diff() command---merged with 50beb3b (RF: Aborb
rev-diff, 2019-04-30)---returns an entry for all files in the working
tree, with unchanged files having a state of "clean".

Filter these out to restore the original behavior and avoid dumping a
large amount of uninteresting information to `rerun --report` callers.
@kyleam
Copy link
Contributor Author

@kyleam kyleam commented Nov 19, 2019

AppVeyor failure is the familiar hanging of test_autoenabled_remote_msg.

This restores behavior from 0.11.x, so I'm hoping it's uncontroversial. Merging.

@kyleam kyleam merged commit 74c99ae into datalad:master Nov 19, 2019
14 of 15 checks passed
@kyleam kyleam deleted the rerun-restrict-diff branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant