Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: siblings: Do not call update() with 'path' argument #3877

Merged
merged 1 commit into from Nov 22, 2019

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented Nov 20, 2019

This patch prevents a spurious warning from an update call in siblings. I noticed it when calling create-sibling:

$ datalad create-sibling -r -s sm smaug:scratch/sib
[INFO   ] Connecting ...
[INFO   ] Considering to create a target dataset /tmp/dl-5RhTQQG at scratch/sib of smaug
[WARNING] path constraints for subdataset updates ignored, because `recursive` option was not given
[INFO   ] Fetching updates for <Dataset path=/tmp/dl-5RhTQQG>
.: sm(+) [smaug:scratch/sib (git)]
[INFO   ] Adjusting remote git configuration
[INFO   ] Running post-update hooks in all created siblings
create_sibling(ok): . (dataset)

As of bc3afae (RF: update() no longer uses AnnotatePaths,
2019-09-22), the path argument of update() only restricts which
subdatasets are updated when operating recursively; it doesn't specify
which top-level dataset to operate on.  And as of 02656cb (ENH:
Better UX in case of misspecified or pointless path constraints,
2019-09-24), update() warns if `path` is specified but `recursive` is
false.

`siblings --fetch` calls update() with a path and recursive=False, but
it wasn't adjusted for the new calling convention, so any direct
callers of `siblings --fetch` as well as create-sibling callers see a
spurious warning.

Drop the path argument from the update() call, passing the
dataset-to-update as the dataset argument.
@kyleam
Copy link
Contributor Author

@kyleam kyleam commented Nov 20, 2019

AppVeyor failure is test_autoenabled_remote_msg stalling.

mih
mih approved these changes Nov 22, 2019
Copy link
Member

@mih mih left a comment

No idea, why that was there.... Thx!

@mih mih merged commit ee5522b into datalad:master Nov 22, 2019
14 of 15 checks passed
@kyleam kyleam deleted the update-update-call branch Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants