Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Speed-up initial status() run in unlock() #3880

Merged
merged 2 commits into from Nov 22, 2019
Merged

Conversation

mih
Copy link
Member

@mih mih commented Nov 21, 2019

it should not be necessary determine the actual file type for unlock's internal need. So all those cycles can be saved.

Discovered in the context of #3869

mih added 2 commits Nov 21, 2019
it should not be necessary determine the actual file type
for unlock's internal need. So all those cycles can be saved.

Discovered in the context of
datalad#3869
Perks:

- we get to report errors
- we bypass path normalization that we know we do not need
@codecov
Copy link

@codecov codecov bot commented Nov 21, 2019

Codecov Report

Merging #3880 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3880      +/-   ##
==========================================
+ Coverage   80.66%   80.68%   +0.02%     
==========================================
  Files         272      272              
  Lines       36014    36014              
==========================================
+ Hits        29050    29059       +9     
+ Misses       6964     6955       -9
Impacted Files Coverage Δ
datalad/interface/unlock.py 98.57% <ø> (ø) ⬆️
datalad/downloaders/tests/test_http.py 60.29% <0%> (+2.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa40951...dff8453. Read the comment docs.

@mih
Copy link
Member Author

@mih mih commented Nov 22, 2019

AppVeyor has familiar time out issues. Will merge this now, the change is trivial and impactful.

@mih mih merged commit f7397c6 into datalad:master Nov 22, 2019
14 of 15 checks passed
@mih mih deleted the enh-unlock branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant