Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Make sure to not issue an install-ok result, before the repo state is final #3906

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

mih
Copy link
Member

@mih mih commented Dec 7, 2019

The underlying issue was discovered in #3903

@mih mih mentioned this pull request Dec 7, 2019
2 tasks
@codecov
Copy link

codecov bot commented Dec 7, 2019

Codecov Report

Merging #3906 into master will increase coverage by 9.7%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3906     +/-   ##
=========================================
+ Coverage   71.01%   80.71%   +9.7%     
=========================================
  Files         272      272             
  Lines       36065    36066      +1     
=========================================
+ Hits        25611    29112   +3501     
+ Misses      10454     6954   -3500
Impacted Files Coverage Δ
datalad/distribution/get.py 85.43% <100%> (+66.41%) ⬆️
datalad/downloaders/tests/test_http.py 58.08% <0%> (-2.21%) ⬇️
datalad/support/tests/test_gitrepo.py 99.89% <0%> (+0.1%) ⬆️
datalad/distribution/tests/test_install.py 99.79% <0%> (+0.2%) ⬆️
datalad/interface/tests/test_rerun.py 100% <0%> (+0.4%) ⬆️
datalad/log.py 65.86% <0%> (+0.48%) ⬆️
datalad/tests/test_config.py 100% <0%> (+1.19%) ⬆️
datalad/downloaders/http.py 61.35% <0%> (+1.19%) ⬆️
datalad/core/local/tests/test_save.py 99.19% <0%> (+1.34%) ⬆️
datalad/metadata/tests/test_search.py 94.96% <0%> (+1.43%) ⬆️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6031944...74ee17a. Read the comment docs.

@mih
Copy link
Member Author

mih commented Dec 8, 2019

Rebased on master after merge of #3904. Could not replicate any of the windows test failures on a win10 box with Git 2.23.

@mih mih added the severity-normal standard severity label Dec 8, 2019
Copy link
Member

@bpoldrack bpoldrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right.

@mih
Copy link
Member Author

mih commented Dec 9, 2019

Cool, thanks!

@mih mih merged commit 9ee994b into datalad:master Dec 9, 2019
@mih mih deleted the bf-installsuccess branch December 9, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity-normal standard severity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants