Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

siblings: Check for remote before inheriting annex settings #3954

Merged
merged 2 commits into from Dec 21, 2019

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented Dec 20, 2019

The first patch adds a basic test for siblings(..., inherit=True). The second prevents siblings(..., inherit=True) from crashing when the parent dataset doesn't include a remote of the same name (reported by @dorianps in gh-3950).

kyleam added 2 commits Dec 20, 2019
The next commit will add a condition to guard part of the inherit=True
code path when a remote with the same name doesn't exist in the
superdataset.  Let's add a basic test to make sure we don't block this
path when the remote does exist.
Calling `datalad siblings add --inherit --name NAME ...` when the
parent dataset doesn't have a remote NAME crashes with git-annex
saying that the dataset doesn't have such a remote.

If a remote with the same name doesn't exist, there's nothing to do,
so avoid this code path.

Fixes datalad#3950.
@codecov
Copy link

@codecov codecov bot commented Dec 20, 2019

Codecov Report

Merging #3954 into 0.11.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.11.x    #3954      +/-   ##
==========================================
+ Coverage   89.96%   89.96%   +<.01%     
==========================================
  Files         253      253              
  Lines       34045    34058      +13     
==========================================
+ Hits        30627    30641      +14     
+ Misses       3418     3417       -1
Impacted Files Coverage Δ
datalad/distribution/siblings.py 76.61% <ø> (+0.3%) ⬆️
datalad/distribution/tests/test_siblings.py 91.53% <100%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a53a87c...c6cc6e0. Read the comment docs.

@yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Dec 21, 2019

Thanks!

@yarikoptic yarikoptic merged commit bc9dd95 into datalad:0.11.x Dec 21, 2019
5 checks passed
@kyleam kyleam deleted the sibling-super-no-remote branch Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants