BF: Always report absolute location of discovered procedures #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it would report relpaths if operating on a dataset, leading to the issue at hand. I considered relpaths for dataset internal procedures, and abspaths for others. However, when not invoked at the root of a dataset these would again be somewhat confusing. So full abspath it is. Fixes dataladgh-3619
Codecov Report
@@ Coverage Diff @@
## master #3959 +/- ##
==========================================
+ Coverage 89.75% 89.77% +0.01%
==========================================
Files 271 271
Lines 36374 36374
==========================================
+ Hits 32649 32656 +7
+ Misses 3725 3718 -7
Continue to review full report at Codecov.
|
kyleam
approved these changes
Dec 23, 2019
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Before it would report relpaths if operating on a dataset, leading to
the issue at hand.
I considered relpaths for dataset internal procedures, and abspaths for
others. However, when not invoked at the root of a dataset these would
again be somewhat confusing. So full abspath it is.
Fixes gh-3619