Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Always report absolute location of discovered procedures #3959

Merged
merged 1 commit into from Dec 23, 2019

Conversation

mih
Copy link
Member

@mih mih commented Dec 21, 2019

Before it would report relpaths if operating on a dataset, leading to
the issue at hand.

I considered relpaths for dataset internal procedures, and abspaths for
others. However, when not invoked at the root of a dataset these would
again be somewhat confusing. So full abspath it is.

Fixes gh-3619

Before it would report relpaths if operating on a dataset, leading to
the issue at hand.

I considered relpaths for dataset internal procedures, and abspaths for
others. However, when not invoked at the root of a dataset these would
again be somewhat confusing. So full abspath it is.

Fixes dataladgh-3619
@codecov
Copy link

@codecov codecov bot commented Dec 21, 2019

Codecov Report

Merging #3959 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3959      +/-   ##
==========================================
+ Coverage   89.75%   89.77%   +0.01%     
==========================================
  Files         271      271              
  Lines       36374    36374              
==========================================
+ Hits        32649    32656       +7     
+ Misses       3725     3718       -7
Impacted Files Coverage Δ
datalad/interface/run_procedure.py 90.06% <ø> (ø) ⬆️
datalad/downloaders/base.py 75.55% <0%> (+0.37%) ⬆️
datalad/downloaders/http.py 75.29% <0%> (+0.39%) ⬆️
datalad/downloaders/tests/test_http.py 61.8% <0%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c38dbd7...af89e92. Read the comment docs.

@mih mih added the merge-if-ok label Dec 23, 2019
kyleam
kyleam approved these changes Dec 23, 2019
@mih
Copy link
Member Author

@mih mih commented Dec 23, 2019

Thx!

@mih mih merged commit d93a617 into datalad:master Dec 23, 2019
17 checks passed
@mih mih deleted the bf-3619 branch Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants