BF: Provide indication which procedure is (to be) execut(ed/able) #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it would report relpaths if operating on a dataset, leading to the issue at hand. I considered relpaths for dataset internal procedures, and abspaths for others. However, when not invoked at the root of a dataset these would again be somewhat confusing. So full abspath it is. Fixes dataladgh-3619
Before only "absent" (but configured) procedures were marked up
in the 'state' field of their result record. Now this is extended
with two more states:
'executable': all criteria for an active procedure are fulfilled
'overridden': like 'executable', but there is a higher-priority
procedure with the same name
These additional states are also reflected in the renderer, where
only active/executable procedures are renderer as before, and
any other's are de-emphasized and annotated.
Fixes dataladgh-3614
Codecov Report
@@ Coverage Diff @@
## master #3960 +/- ##
==========================================
+ Coverage 89.75% 89.78% +0.02%
==========================================
Files 271 271
Lines 36374 36375 +1
==========================================
+ Hits 32649 32659 +10
+ Misses 3725 3716 -9
Continue to review full report at Codecov.
|
kyleam
approved these changes
Dec 23, 2019
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
[Sits on top of https://github.com//pull/3959 to avoid conflicts]
Before, only "absent" (but configured) procedures were marked up in the 'state' field of their result record. Now this is extended with two more states:
These additional states are also reflected in the renderer, where only active/executable procedures are renderer as before, and any other's are de-emphasized and annotated.
Fixes gh-3614
Example output before
% dl run-procedure --discover
cfg_inm7 (/etc/xdg/datalad/procedures/cfg_inm7.py) [python_script]
cfg_inm7 (/home/mih/hacking/datalad/inm7-datalad/inm7_datalad/resources/procedures/cfg_inm7.py) [python_script]
ria_post_install (/home/mih/hacking/datalad/git-annex-ria-remote/ria_remote/resources/procedures/ria_post_install.py) [python_script]
after
% datalad run-procedure --discover
cfg_inm7 (/etc/xdg/datalad/procedures/cfg_inm7.py) [python_script]
cfg_inm7 (/home/mih/hacking/datalad/inm7-datalad/inm7_datalad/resources/procedures/cfg_inm7.py) [python_script (overridden)]
ria_post_install (/home/mih/hacking/datalad/git-annex-ria-remote/ria_remote/resources/procedures/ria_post_install.py) [python_script]
or in full: