Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Store path URLs for remotes in POSIX (fixes gh-3972) #3976

Merged
merged 2 commits into from Jan 2, 2020
Merged

Conversation

mih
Copy link
Member

@mih mih commented Jan 1, 2020

with a test.

mih added 2 commits Jan 1, 2020
Windows remote path URLs are not stored in POSIX convention (like Git
one would do for origin), but full native (with backslashes)
@codecov
Copy link

@codecov codecov bot commented Jan 1, 2020

Codecov Report

Merging #3976 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3976      +/-   ##
=========================================
- Coverage   89.76%   89.7%   -0.07%     
=========================================
  Files         271     271              
  Lines       36328   36323       -5     
=========================================
- Hits        32610   32582      -28     
- Misses       3718    3741      +23
Impacted Files Coverage Δ
datalad/distribution/siblings.py 76.89% <100%> (+0.14%) ⬆️
datalad/distribution/tests/test_siblings.py 92.02% <100%> (-0.39%) ⬇️
datalad/downloaders/tests/test_http.py 58.39% <0%> (-3.41%) ⬇️
datalad/downloaders/http.py 72.11% <0%> (-3.19%) ⬇️
datalad/downloaders/base.py 75.18% <0%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af135de...ee1ece0. Read the comment docs.

@mih
Copy link
Member Author

@mih mih commented Jan 2, 2020

This should be uncontroversial. Will merge.

@mih mih merged commit 430158d into datalad:master Jan 2, 2020
17 checks passed
@mih mih deleted the bf-3972 branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant