Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: update -- do not save if no --merge, use save instead of Dataset(refds_path).add #3996

Merged
merged 1 commit into from Jan 11, 2020

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Jan 9, 2020

refds_path could be empty if dataset is not specified but path (to subdataset) is provided

Note that it would change existing behavior -- apparently we could have been saving some prior changes if there were some before running update. I would consider that also to be a bug fix

Fixes #3097
ref: templateflow/templateflow#5

TODOs (after merge)

  • merge/adjust for master way of things

…refds_path).add

refds_path could be None, so it would cause Dataset to blow.
@codecov
Copy link

@codecov codecov bot commented Jan 9, 2020

Codecov Report

Merging #3996 into 0.11.x will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.11.x    #3996      +/-   ##
==========================================
+ Coverage   89.92%   89.96%   +0.04%     
==========================================
  Files         253      253              
  Lines       34078    34085       +7     
==========================================
+ Hits        30643    30666      +23     
+ Misses       3435     3419      -16
Impacted Files Coverage Δ
datalad/distribution/tests/test_update.py 100% <100%> (ø) ⬆️
datalad/distribution/update.py 98.14% <100%> (+0.01%) ⬆️
datalad/downloaders/tests/test_http.py 91.15% <0%> (+2.21%) ⬆️
datalad/downloaders/http.py 87.3% <0%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4776c27...41d36ac. Read the comment docs.

@bpoldrack
Copy link
Member

@bpoldrack bpoldrack commented Jan 9, 2020

LGTM

@yarikoptic yarikoptic merged commit dc64c39 into datalad:0.11.x Jan 11, 2020
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants