Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF: Clone of subdatasets uses reckless mode of superdataset (fixes gh-4030) #4037

Merged
merged 1 commit into from Jan 20, 2020

Conversation

mih
Copy link
Member

@mih mih commented Jan 17, 2020

If --reckless is given, the label is stored verbatim under config
variable datalad.clone.reckless. clone() consults this variable
whenever --reckless is None.

As a consequence of this change, subdatasets will inherit any reckless
mode.

Obviously, this also makes it possible to provide global configuration
to force a particular reckless mode for any cloned dataset.

…taladgh-4030)

If --reckless is given, the label is stored verbatim under config
variable `datalad.clone.reckless`. `clone()` consults this variable
whenever `--reckless` is None.

As a consequence of this change, subdatasets will inherit any reckless
mode.

Obviously, this also makes it possible to provide global configuration
to force a particular reckless mode for any cloned dataset.
@mih mih added the merge-if-ok label Jan 17, 2020
@mih
Copy link
Member Author

@mih mih commented Jan 17, 2020

Test failure might be due to external service unavailability.

@codecov
Copy link

@codecov codecov bot commented Jan 17, 2020

Codecov Report

Merging #4037 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4037      +/-   ##
==========================================
+ Coverage   89.78%   89.78%   +<.01%     
==========================================
  Files         272      272              
  Lines       36536    36544       +8     
==========================================
+ Hits        32804    32812       +8     
  Misses       3732     3732
Impacted Files Coverage Δ
datalad/interface/common_opts.py 100% <ø> (ø) ⬆️
datalad/core/distributed/tests/test_clone.py 90.6% <100%> (+0.12%) ⬆️
datalad/core/distributed/clone.py 92.92% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47980eb...1a2e9e4. Read the comment docs.

@mih
Copy link
Member Author

@mih mih commented Jan 19, 2020

FTR: I will merge this on Monday, unless objections are expressed.

@mih mih merged commit fca2866 into datalad:master Jan 20, 2020
17 checks passed
@mih mih deleted the clonereckless branch Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant