Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace shlex.quote() with quote_cmdlinearg() #4050

Merged
merged 3 commits into from Jan 20, 2020
Merged

Replace shlex.quote() with quote_cmdlinearg() #4050

merged 3 commits into from Jan 20, 2020

Conversation

mih
Copy link
Member

@mih mih commented Jan 19, 2020

This enables more appropriate command-line argument quoting on
windows, and will retain the previous behavior on any other platform.

This could potentially improve SSH support on Windows substantially,
because shlex.quote() was often inappropriately and unconditionally
used in associated code.

  • also replace maybe_shlex_quote()

mih added 2 commits Jan 19, 2020
A helper that actually performs meaningful quoting on Windows too.
This enables more appropriate command-line argument quoting on
windows, and will retain the previous behavior on any other platform.

This could potentially improve SSH support on Windows substantially,
because shlex.quote() was often inappropriately and unconditionally
used in associated code.
@codecov
Copy link

@codecov codecov bot commented Jan 19, 2020

Codecov Report

Merging #4050 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4050      +/-   ##
==========================================
- Coverage   89.77%   89.74%   -0.04%     
==========================================
  Files         273      273              
  Lines       36570    36569       -1     
==========================================
- Hits        32831    32819      -12     
- Misses       3739     3750      +11
Impacted Files Coverage Δ
datalad/interface/utils.py 93.67% <ø> (-0.03%) ⬇️
datalad/utils.py 87.26% <100%> (ø) ⬆️
datalad/core/local/run.py 98.7% <100%> (ø) ⬆️
datalad/interface/run_procedure.py 90.74% <100%> (ø) ⬆️
datalad/interface/tests/test_run_procedure.py 100% <100%> (ø) ⬆️
datalad/support/sshconnector.py 85.77% <100%> (ø) ⬆️
datalad/core/local/tests/test_run.py 99.55% <100%> (ø) ⬆️
datalad/downloaders/http.py 72.11% <0%> (-2.79%) ⬇️
datalad/downloaders/tests/test_http.py 58.39% <0%> (-2.19%) ⬇️
datalad/tests/test_config.py 98.92% <0%> (-1.08%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7493e4...0c058da. Read the comment docs.

@mih
Copy link
Member Author

@mih mih commented Jan 20, 2020

Going in. Will RF #4041 to make use of it.

@mih mih merged commit 246e010 into datalad:master Jan 20, 2020
17 checks passed
@mih mih deleted the bf-4048 branch Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant