BF: Don't be silent in default renderer when everything is clean #4106
Conversation
Follow up to a user report consider no output confusing. `status` now follows `git status` in wording. Fixes dataladgh-3916
|
Appveyor failure is failure to upload coverage. |
datalad/core/local/status.py
Outdated
| @@ -473,3 +473,6 @@ def custom_result_summary_renderer(results): # pragma: more cover | |||
| len(annexed), | |||
| single_or_plural('file', 'files', len(annexed)), | |||
| total_size)) | |||
| if all(r.get('state', None) == 'clean' for r in results): | |||
There was a problem hiding this comment.
Is it valid to assume that every result coming through is action='status'? It looks like code just upstream does not make this assumption.
There was a problem hiding this comment.
Good Q. Will investigate and add a filter, if needed. Thx!
There was a problem hiding this comment.
I have added the check. Even if it is not necessary now, we run the risk of silently breaking it in the future, if it is no ensured.
Codecov Report
@@ Coverage Diff @@
## master #4106 +/- ##
==========================================
- Coverage 89.7% 89.64% -0.07%
==========================================
Files 274 274
Lines 36754 36759 +5
==========================================
- Hits 32971 32953 -18
- Misses 3783 3806 +23
Continue to review full report at Codecov.
|
Follow up on a report by @dorianps considering no output confusing.
statusnow follows
git statusin wording.Fixes gh-3916