Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Don't be silent in default renderer when everything is clean #4106

Merged
merged 2 commits into from Feb 1, 2020

Conversation

mih
Copy link
Member

@mih mih commented Jan 30, 2020

Follow up on a report by @dorianps considering no output confusing. status
now follows git status in wording.

Fixes gh-3916

(datalad3-dev) mih@meiner ~/hacking/datalad/git (git)-[bf-3916] % datalad status
nothing to save, working tree clean

Follow up to a user report consider no output confusing. `status`
now follows `git status` in wording.

Fixes dataladgh-3916
@mih mih added the UX user experience label Jan 30, 2020
@mih
Copy link
Member Author

@mih mih commented Jan 30, 2020

Appveyor failure is failure to upload coverage.

@mih mih added the merge-if-ok OP considers this work done, and requests review/merge label Jan 30, 2020
@@ -473,3 +473,6 @@ def custom_result_summary_renderer(results): # pragma: more cover
len(annexed),
single_or_plural('file', 'files', len(annexed)),
total_size))
if all(r.get('state', None) == 'clean' for r in results):
Copy link
Contributor

@kyleam kyleam Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it valid to assume that every result coming through is action='status'? It looks like code just upstream does not make this assumption.

Copy link
Member Author

@mih mih Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Q. Will investigate and add a filter, if needed. Thx!

Copy link
Member Author

@mih mih Feb 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the check. Even if it is not necessary now, we run the risk of silently breaking it in the future, if it is no ensured.

@codecov
Copy link

@codecov codecov bot commented Feb 1, 2020

Codecov Report

Merging #4106 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4106      +/-   ##
==========================================
- Coverage    89.7%   89.64%   -0.07%     
==========================================
  Files         274      274              
  Lines       36754    36759       +5     
==========================================
- Hits        32971    32953      -18     
- Misses       3783     3806      +23
Impacted Files Coverage Δ
datalad/core/local/status.py 98.09% <100%> (+0.05%) ⬆️
datalad/log.py 82.69% <0%> (-7.22%) ⬇️
datalad/tests/test_log.py 98.03% <0%> (-0.99%) ⬇️
datalad/support/tests/test_annexrepo.py 94.98% <0%> (-0.47%) ⬇️
datalad/support/network.py 86.4% <0%> (-0.24%) ⬇️
datalad/interface/download_url.py 97.91% <0%> (ø) ⬆️
datalad/cmdline/main.py 77.4% <0%> (ø) ⬆️
datalad/distribution/install.py 98.87% <0%> (ø) ⬆️
datalad/core/local/run.py 98.7% <0%> (ø) ⬆️
datalad/core/distributed/clone.py 93.07% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 458b2df...aed5116. Read the comment docs.

kyleam
kyleam approved these changes Feb 1, 2020
@mih mih merged commit d171bc8 into datalad:master Feb 1, 2020
16 of 17 checks passed
@mih mih deleted the bf-3916 branch Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok OP considers this work done, and requests review/merge UX user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants