NF: create-sibling-ria command #4124
@@ Coverage Diff @@ ## master #4124 +/- ## ========================================= Coverage ? 89.54% ========================================= Files ? 279 Lines ? 36707 Branches ? 0 ========================================= Hits ? 32868 Misses ? 3839 Partials ? 0
Finally able to reproduce issue on Travis. Reason: Happens only on the merge commit with master. At least twofold:
As suspected (but not traced down) before: We shoot our feet with the fake $HOME we set up for tests:
Note, that it reads
And number 3:
Above mentioned wrong order brought some headache, since it should only lead to not setting the publication dependency. Instead, special remote wasn't enabled at all. How so? Turns out, that the search for such a special remote results in annex-calls like
Before we can deal with special remotes, we need to figure it's an annex and initialize it. Also: Local config settings in postprocessing don't make sense, if we only afterwards double-check that we do indeed have an installed dataset as a result, etc. Furthermore, there's a possible bug in annex, where git-annex-info (indirectly called by postclonecfg_ria) half-initializes the repo preventing us from later detect, that we still need to do it (particularly in order to autoenable special remotes). See issue datalad#4152.
This avoids the need for any
The failure doesn't happen with a URL that doesn't have a user specified. It is likely a URL parsing issue.
Consider something like url.ria+ssh://user@host/some/where.insteadOf MYLABEL and using it with datalad-clone or datalad-create-sibling-ria. That would mean to pass just MYLABEL as the url parameter. We wouldn't even recognize it as an URL before rewriting.
FTR: Windows failure is in
Note, that this is about github Win2019 tests. appveyor fails with the known coverage issue only.
Restarted build after failure didn't happen in master. Now it passes. So - whatever.