Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: export-to-figshare - make default title include #id@version, ask for the title in UI #4140

Merged
merged 2 commits into from Feb 13, 2020

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Feb 13, 2020

Decided not to expose title specification in API since the whole experience is interactive, but I guess it could be added.

Closes #4138

@yarikoptic yarikoptic added this to the 0.12.3 milestone Feb 13, 2020
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #4140 into master will increase coverage by 46.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4140       +/-   ##
===========================================
+ Coverage   42.90%   89.23%   +46.33%     
===========================================
  Files         275      276        +1     
  Lines       36997    37127      +130     
===========================================
+ Hits        15872    33130    +17258     
+ Misses      21125     3997    -17128     
Impacted Files Coverage Δ
datalad/support/due.py 48.00% <0.00%> (-28.00%) ⬇️
datalad/support/archive_utils_patool.py 29.87% <0.00%> (-10.39%) ⬇️
datalad/ui/utils.py 46.87% <0.00%> (-6.25%) ⬇️
datalad/tests/test_archives.py 90.57% <0.00%> (-4.35%) ⬇️
datalad/interface/common_opts.py 100.00% <0.00%> (ø) ⬆️
datalad/plugin/tests/test_export_to_figshare.py 100.00% <0.00%> (ø)
datalad/cmdline/tests/test_main.py 95.74% <0.00%> (+0.70%) ⬆️
datalad/core/local/create.py 94.77% <0.00%> (+0.74%) ⬆️
datalad/core/local/tests/test_create.py 100.00% <0.00%> (+0.90%) ⬆️
datalad/support/external_versions.py 95.62% <0.00%> (+1.45%) ⬆️
... and 187 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66da58e...f68bfc0. Read the comment docs.

@yarikoptic yarikoptic added the merge-if-ok OP considers this work done, and requests review/merge label Feb 13, 2020
kyleam
kyleam approved these changes Feb 13, 2020
@yarikoptic
Copy link
Member Author

yarikoptic commented Feb 13, 2020

ok, earned an approval, thank you @kyleam

@yarikoptic yarikoptic merged commit 035f5c0 into datalad:master Feb 13, 2020
4 checks passed
@yarikoptic yarikoptic modified the milestones: 0.12.3, 0.12.x Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok OP considers this work done, and requests review/merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export-to-figshare can fail with 400 response code from figshare
2 participants