Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: GitRepo.commit() based on WitlessRunner #4156

Merged
merged 1 commit into from Feb 20, 2020
Merged

Conversation

mih
Copy link
Member

@mih mih commented Feb 16, 2020

Previous (positive) API and behavior are maintained, except for the lack
of 'protocol' support which is only available in the traditional runner.

In addition, when multiple calls to git-commit need to be made, --amend
is now used from the second call onward to avoid leaving multiple
commits behind for technical reasons, when conceptually there is only
as single changeset. Fixes gh-3914

This is a trimmed down changeset from a previous attempt to enable
interactive commit messages. Compare to
aa86a8d to recover the discarded diff.

Replaces #4121 for the time being...

@mih
Copy link
Member Author

mih commented Feb 17, 2020

Re test failures:

  • Appveyor is coverage submission
  • github ci windows is some incompatibility with shortpaths in the ancient pre 0.12 save/add code -- I will try to jump-start Removal of obsolete add/save #3735 again, instead of wasting time on fixing this code up again.

@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #4156 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4156      +/-   ##
==========================================
- Coverage   89.44%   89.40%   -0.04%     
==========================================
  Files         272      272              
  Lines       35598    35596       -2     
==========================================
- Hits        31842    31826      -16     
- Misses       3756     3770      +14     
Impacted Files Coverage Δ
datalad/downloaders/http.py 72.11% <0.00%> (-2.79%) ⬇️
datalad/downloaders/tests/test_http.py 58.39% <0.00%> (-2.19%) ⬇️
datalad/support/network.py 86.40% <0.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd4bc3...f635ace. Read the comment docs.

Previous (positive) API and behavior are maintained, except for the lack
of 'protocol' support which is only available in the traditional runner.

In addition, when multiple call to git-commit need to be made, --amend
is now used from the second call onwards to avoid leaving multiple
commits behind for technical reasons, when conceptually there is only
as single changeset. Fixes dataladgh-3914

This is a trimmed down changeset from a previous attempt to enable
interactive commit messages. Compare to
aa86a8d to recover the discarded diff.
@mih mih added the merge-if-ok label Feb 19, 2020
@mih mih merged commit 34383e4 into datalad:master Feb 20, 2020
16 of 17 checks passed
@mih mih deleted the rf-asynccommit branch Feb 20, 2020
@yarikoptic yarikoptic added this to the 0.13.0 milestone Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants