RF: GitRepo.commit() based on WitlessRunner #4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re test failures:
|
Codecov Report
@@ Coverage Diff @@
## master #4156 +/- ##
==========================================
- Coverage 89.44% 89.40% -0.04%
==========================================
Files 272 272
Lines 35598 35596 -2
==========================================
- Hits 31842 31826 -16
- Misses 3756 3770 +14
Continue to review full report at Codecov.
|
5 tasks
Previous (positive) API and behavior are maintained, except for the lack of 'protocol' support which is only available in the traditional runner. In addition, when multiple call to git-commit need to be made, --amend is now used from the second call onwards to avoid leaving multiple commits behind for technical reasons, when conceptually there is only as single changeset. Fixes dataladgh-3914 This is a trimmed down changeset from a previous attempt to enable interactive commit messages. Compare to aa86a8d to recover the discarded diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Previous (positive) API and behavior are maintained, except for the lack
of 'protocol' support which is only available in the traditional runner.
In addition, when multiple calls to git-commit need to be made, --amend
is now used from the second call onward to avoid leaving multiple
commits behind for technical reasons, when conceptually there is only
as single changeset. Fixes gh-3914
This is a trimmed down changeset from a previous attempt to enable
interactive commit messages. Compare to
aa86a8d to recover the discarded diff.
Replaces #4121 for the time being...