Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of obsolete add/save (2nd attempt) #4158

Merged
merged 3 commits into from Feb 19, 2020
Merged

Removal of obsolete add/save (2nd attempt) #4158

merged 3 commits into from Feb 19, 2020

Conversation

mih
Copy link
Member

@mih mih commented Feb 17, 2020

This revitalizes #3735 but this time with the goal of getting it merged soon. It is critical for #3368 and will likely involve a relatively elaborate RF.

Tests will go green with #4163

Related:

@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #4158 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4158      +/-   ##
==========================================
- Coverage   89.50%   89.38%   -0.12%     
==========================================
  Files         276      272       -4     
  Lines       36487    35598     -889     
==========================================
- Hits        32656    31818     -838     
+ Misses       3831     3780      -51     
Impacted Files Coverage Δ
datalad/interface/annotate_paths.py 90.18% <0.00%> (-4.37%) ⬇️
datalad/interface/tests/test_unlock.py 95.65% <0.00%> (-2.18%) ⬇️
datalad/interface/diff.py 93.75% <0.00%> (-1.88%) ⬇️
datalad/tests/utils.py 88.07% <0.00%> (-1.74%) ⬇️
datalad/support/annexrepo.py 84.98% <0.00%> (-1.09%) ⬇️
datalad/core/local/tests/test_save.py 97.31% <0.00%> (-0.54%) ⬇️
datalad/support/tests/test_annexrepo.py 95.17% <0.00%> (-0.41%) ⬇️
datalad/tests/test_utils.py 95.65% <0.00%> (-0.29%) ⬇️
datalad/support/gitrepo.py 90.28% <0.00%> (-0.25%) ⬇️
datalad/tests/test_log.py 98.90% <0.00%> (+1.09%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec1f828...6bcef59. Read the comment docs.

@mih
Copy link
Member Author

mih commented Feb 19, 2020

Final test run after #4163 will merge when all is green.

@mih
Copy link
Member Author

mih commented Feb 19, 2020

All green. Ignition!

@mih mih merged commit 7bd4bc3 into datalad:master Feb 19, 2020
16 of 17 checks passed
@mih mih deleted the rf-noadd branch Feb 19, 2020
@yarikoptic yarikoptic added this to the 0.13.0 milestone Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants