Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Remove GitRepo.get_changed_files() and its last usage #4169

Merged
merged 1 commit into from Feb 20, 2020

Conversation

mih
Copy link
Member

@mih mih commented Feb 20, 2020

This PR sits on top of #4168, but is kept separate to not block it due to a potential issue with this changeset.

GitRepo.get_changed_files() still used the GitPy diff interface, its last and only usage
was replaced by GitRepo.call_git_items_()

This furthers gh-2970

@mih mih mentioned this pull request Feb 20, 2020
15 tasks
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #4169 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4169      +/-   ##
==========================================
+ Coverage   89.12%   89.14%   +0.02%     
==========================================
  Files         275      275              
  Lines       35814    35800      -14     
==========================================
- Hits        31918    31914       -4     
+ Misses       3896     3886      -10
Impacted Files Coverage Δ
datalad/support/gitrepo.py 90.49% <ø> (+0.26%) ⬆️
datalad/support/annexrepo.py 84.07% <100%> (ø) ⬆️
datalad/support/network.py 85.94% <0%> (-0.24%) ⬇️
datalad/support/tests/test_annexrepo.py 95.57% <0%> (+0.32%) ⬆️
datalad/support/tests/test_cookies.py 100% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f814ab...c2e5fb3. Read the comment docs.

@mih
Copy link
Member Author

mih commented Feb 20, 2020

Windows failure is unrelated to this PR and happens elsewhere too.

@mih
Copy link
Member Author

mih commented Feb 20, 2020

Windows github ci failure is unrelated and happens unreliably and elsewhere too.

This method still used the GitPy diff interface, it last and only usage
was replaced by GitRepo.call_git_items_()

This furthers dataladgh-2970
@mih
Copy link
Member Author

mih commented Feb 20, 2020

Rebased after merge of #4168

kyleam
kyleam approved these changes Feb 20, 2020
@mih
Copy link
Member Author

mih commented Feb 20, 2020

Thx @kyleam !

@mih mih merged commit 8eb8dd1 into datalad:master Feb 20, 2020
13 of 15 checks passed
@mih mih deleted the cln-getchanged branch Feb 20, 2020
@yarikoptic yarikoptic added this to the 0.13.0 milestone Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants