Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: list datalad-container extension provided commands #4174

Merged
merged 1 commit into from Feb 21, 2020

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Feb 20, 2020

So a user would get a hint when he uses the command without datalad-container
extension being installed:

$> datalad containers-list
datalad: Unknown command 'containers-list'.  See 'datalad --help'.

Hint: Command containers-list is provided by (not installed) extension datalad-container.

So a user would get a hint when he uses the command without datalad-container
extension being installed:

$> datalad containers-list
datalad: Unknown command 'containers-list'.  See 'datalad --help'.

Hint: Command containers-list is provided by (not installed) extension datalad-container.
@yarikoptic yarikoptic added this to the 0.12.3 milestone Feb 20, 2020
@yarikoptic
Copy link
Member Author

@yarikoptic yarikoptic commented Feb 20, 2020

Failure in datalad-container extension is inflicted by #3834 with fix pending in datalad/datalad-crawler#66, so unrelated to these changes

@kyleam
Copy link
Contributor

@kyleam kyleam commented Feb 20, 2020

Failure in datalad-container extension is inflicted ...

You mean datalad-crawler, presumably.

kyleam
kyleam approved these changes Feb 20, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 20, 2020

Codecov Report

Merging #4174 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4174      +/-   ##
==========================================
- Coverage   89.09%   88.97%   -0.13%     
==========================================
  Files         275      275              
  Lines       35777    35777              
==========================================
- Hits        31876    31831      -45     
- Misses       3901     3946      +45     
Impacted Files Coverage Δ
datalad/customremotes/tests/__init__.py 91.66% <0.00%> (-8.34%) ⬇️
datalad/downloaders/tests/test_http.py 58.39% <0.00%> (-3.41%) ⬇️
datalad/downloaders/http.py 70.91% <0.00%> (-3.19%) ⬇️
datalad/interface/tests/test_unlock.py 95.65% <0.00%> (-2.18%) ⬇️
datalad/customremotes/tests/test_archives.py 88.88% <0.00%> (-0.66%) ⬇️
datalad/support/annexrepo.py 83.30% <0.00%> (-0.78%) ⬇️
datalad/core/local/tests/test_save.py 97.31% <0.00%> (-0.54%) ⬇️
datalad/support/tests/test_annexrepo.py 94.68% <0.00%> (-0.41%) ⬇️
datalad/downloaders/base.py 75.18% <0.00%> (-0.38%) ⬇️
datalad/tests/test_utils.py 95.36% <0.00%> (-0.29%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c5eee...0a3dc29. Read the comment docs.

@yarikoptic
Copy link
Member Author

@yarikoptic yarikoptic commented Feb 21, 2020

Failure in datalad-container extension is inflicted ...

You mean datalad-crawler, presumably.

yes, exactly! ;)

@yarikoptic
Copy link
Member Author

@yarikoptic yarikoptic commented Feb 21, 2020

no brainer, approverd, merging

@yarikoptic yarikoptic merged commit 0a4397f into datalad:master Feb 21, 2020
15 of 17 checks passed
@yarikoptic yarikoptic removed this from the 0.12.3 milestone Feb 27, 2020
@yarikoptic yarikoptic added this to the 0.12.x milestone Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants