Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Use ConfigManager instead of GitPython config classes #4175

Merged
merged 3 commits into from Feb 21, 2020

Conversation

mih
Copy link
Member

@mih mih commented Feb 20, 2020

Also strips an unused function with such code.

@codecov
Copy link

@codecov codecov bot commented Feb 20, 2020

Codecov Report

Merging #4175 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4175      +/-   ##
==========================================
- Coverage   89.10%   89.05%   -0.06%     
==========================================
  Files         275      275              
  Lines       35777    35803      +26     
==========================================
+ Hits        31880    31885       +5     
- Misses       3897     3918      +21     
Impacted Files Coverage Δ
datalad/downloaders/http.py 70.91% <0.00%> (-2.79%) ⬇️
datalad/downloaders/tests/test_http.py 58.39% <0.00%> (-2.19%) ⬇️
datalad/interface/tests/test_unlock.py 95.65% <0.00%> (-2.18%) ⬇️
datalad/support/annexrepo.py 83.27% <0.00%> (-0.80%) ⬇️
datalad/core/local/tests/test_save.py 97.31% <0.00%> (-0.54%) ⬇️
datalad/tests/test_utils.py 95.36% <0.00%> (-0.29%) ⬇️
datalad/support/tests/test_annexrepo.py 94.66% <0.00%> (-0.10%) ⬇️
datalad/cmd.py 93.17% <0.00%> (-0.02%) ⬇️
datalad/cmdline/main.py 79.91% <0.00%> (ø) ⬆️
datalad/support/tests/test_gitrepo.py 99.76% <0.00%> (+<0.01%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c435a...dc92c9a. Read the comment docs.

@mih
Copy link
Member Author

@mih mih commented Feb 21, 2020

Windows problems are related to the familiar (two many open files issue), not caused by this PR.

@mih mih merged commit 780d047 into datalad:master Feb 21, 2020
13 of 17 checks passed
@mih mih deleted the rf-nogitpyconfig branch Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant