Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF(workaround): position --debug AFTER other annex_options #4212

Merged
merged 1 commit into from Feb 28, 2020

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Feb 27, 2020

Issue filed within annex: https://git-annex.branchable.com/bugs/--debug_is_not_in_effect_if_precedes_-c/

verified that works, no dedicated test

@yarikoptic yarikoptic added the merge-if-ok label Feb 27, 2020
@yarikoptic yarikoptic added this to the 0.12.3 milestone Feb 27, 2020
@yarikoptic
Copy link
Member Author

@yarikoptic yarikoptic commented Feb 27, 2020

said to be fix in git annex 8.20200226-3-gc089f395b .
CI fails here do not make sense in relation to the change, restarted two travis run and a run on windows actions, which had

======================================================================
ERROR: datalad.tests.test_utils.test_get_open_files
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\hostedtoolcache\windows\Python\3.7.6\x64\lib\site-packages\nose\case.py", line 198, in runTest
    self.test(*self.arg)
  File "C:\hostedtoolcache\windows\Python\3.7.6\x64\lib\site-packages\datalad\tests\utils.py", line 586, in newfunc
    return t(*(arg + (d,)), **kw)
  File "C:\hostedtoolcache\windows\Python\3.7.6\x64\lib\site-packages\datalad\tests\test_utils.py", line 1206, in test_get_open_files
    eq_(get_open_files(subd)[op.realpath(subd)].pid, proc.pid)
KeyError: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\datalad_temp_tree_s2oxmdpy\\d'

failure

@kyleam
Copy link
Contributor

@kyleam kyleam commented Feb 27, 2020

LGTM. Do you want to rebase it to maint? (Fine by me if you don't think you need it there or you'd rather just cherry pick it at this point.)

@codecov
Copy link

@codecov codecov bot commented Feb 27, 2020

Codecov Report

Merging #4212 into master will decrease coverage by 0.48%.
The diff coverage is 93.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4212      +/-   ##
==========================================
- Coverage   89.67%   89.19%   -0.49%     
==========================================
  Files         274      275       +1     
  Lines       36744    36126     -618     
==========================================
- Hits        32951    32221     -730     
- Misses       3793     3905     +112
Impacted Files Coverage Δ
datalad/interface/common_opts.py 100% <ø> (ø) ⬆️
datalad/distributed/create_sibling_gitlab.py 74.67% <ø> (ø) ⬆️
datalad/core/local/tests/test_run.py 99.55% <ø> (ø) ⬆️
datalad/local/tests/test_subdataset.py 100% <ø> (ø) ⬆️
datalad/core/local/tests/test_diff.py 96.9% <ø> (-2.58%) ⬇️
datalad/core/local/tests/test_resulthooks.py 100% <ø> (ø) ⬆️
datalad/distribution/get.py 88.78% <ø> (ø) ⬆️
datalad/interface/__init__.py 100% <ø> (ø) ⬆️
datalad/log.py 82.69% <ø> (-7.22%) ⬇️
datalad/core/local/tests/test_status.py 98.85% <ø> (-0.02%) ⬇️
... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59f35c...96da06c. Read the comment docs.

@yarikoptic
Copy link
Member Author

@yarikoptic yarikoptic commented Feb 27, 2020

If you could CP into maint, I am even ok to close this PR without merging. I assume that maint would get a merge into master at some point. Please proceed in your preferred way

@yarikoptic
Copy link
Member Author

@yarikoptic yarikoptic commented Feb 27, 2020

BTW, given now present maint branch, my milestone allocations to 0.12.3 probably wouldn't be "factual" since likely maint would get released as 0.12.3. i have moved majority of issues and prs into 0.12.x milestone, while leaving some open PRs allocated to 0.12.3 (although not all are on top of maint). Please reassign as you see fit, or reassign other possibly merged PRs into 0.12.3 as what we would like to see in maint and released along with 0.12.3

@kyleam kyleam changed the base branch from master to maint Feb 28, 2020
@kyleam kyleam merged commit 4f3dbac into datalad:maint Feb 28, 2020
1 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants