Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Extend rsync-like diff(path='subds/') to path constraints within the subds #4235

Merged
merged 1 commit into from Mar 3, 2020

Conversation

mih
Copy link
Member

@mih mih commented Mar 3, 2020

When called with a trailing slash in a path argument matching a subdataset,
diff() will report on the content, not only on the subdataset record in
its superdataset -- even with recursive=False.

While this is not universally loved, it makes sense to not limit this
behavior to a single trailing slash.

When subds/ reports on the entire subdataset, subds/subdir will now
only report on the content within subdir of subds.

Split from #4206

… the subds

When called with a trailing slash in a path argument matching a subdataset,
`diff()` will report on the content, not only on the subdataset record in
its superdataset -- even with `recursive=False`.

While this is not universally loved, it makes sense to not limit this
behavior to a single trailing slash.

When `subds/` reports on the entire subdataset, `subds/subdir` will now
only report on the content within `subdir` of `subds`.
@mih
Copy link
Member Author

@mih mih commented Mar 3, 2020

Test failure will be fixed with #4237

@mih mih merged commit 518e700 into datalad:master Mar 3, 2020
14 of 15 checks passed
@mih mih deleted the enh-diff branch Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant