Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Move git-annex-ria-remote to datalad core as git-annex-ora-remote (2nd attempt) #4260

Merged
merged 26 commits into from Mar 8, 2020

Conversation

mih
Copy link
Member

@mih mih commented Mar 7, 2020

This PR sits on top of #4258, and incorporates and replaces #4164.

Major changes in addition to those two base PRs are:

mih and others added 25 commits Mar 7, 2020
Remove entirely when not necessary. If necessary 'ria' refers to the
concept of a store, whether the datasets are addressable by their
dataset ID.

A further renaming will happen as part of dataladgh-4164, where 'ria-remote'
(the special remote implementation) is replaced by 'ora-remote'.

Together, this changes disambiguate the term 'ria'.

This change also removes TODOs from the documentation.
This is (almost) a plain copy from original repository at github.com/datalad/git-annex-ria-remote.
We currently can't properly deal with file-scheme URIs for windows
paths.
Tests and url config for special remote need to change anyway, may be
it's actually doable then.
actually implemented for get over SSH only ATM
The stored URL of the special remote in the git-annex branch
might be invalid on another system. If autoenable fails on
clone, it could now read the UUID of the special remote, that
was supposed to be enabled, fallback to the clone-URL and try
again to enable it.
Don't store the URL, that was passed to initremote in git-annex:remote.log,
but the rewritten URL. Otherwise it would be invalid on another system,
that lacks the replacement config (url.<base>.insteadOf)
We easily exceed Travis time limit otherwise.
Use @turtle to mark a test as too slow to run on Travis.
This test takes just too long for Travis.
The behavior of printf is more predictable across systems.
@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #4260 into master will decrease coverage by 0.72%.
The diff coverage is 49.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4260      +/-   ##
==========================================
- Coverage   89.43%   88.70%   -0.73%     
==========================================
  Files         275      282       +7     
  Lines       36182    36887     +705     
==========================================
+ Hits        32358    32721     +363     
- Misses       3824     4166     +342     
Impacted Files Coverage Δ
datalad/api.py 75.86% <0.00%> (-17.25%) ⬇️
datalad/plugin/wtf.py 82.20% <0.00%> (-6.78%) ⬇️
datalad/downloaders/http.py 72.11% <0.00%> (-2.79%) ⬇️
datalad/cmdline/main.py 77.40% <0.00%> (-2.52%) ⬇️
datalad/downloaders/tests/test_http.py 58.39% <0.00%> (-2.19%) ⬇️
datalad/interface/run_procedure.py 90.74% <0.00%> (-1.86%) ⬇️
datalad/support/_lru_cache2.py
...atalad/distributed/tests/test_ria_data_transfer.py 71.42% <0.00%> (ø)
datalad/distributed/tests/test_ria_config.py 100.00% <0.00%> (ø)
datalad/distributed/tests/test_ria_gitannex.py 70.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32921eb...11dd006. Read the comment docs.

@mih mih mentioned this pull request Mar 7, 2020
5 tasks
@mih
Copy link
Member Author

mih commented Mar 8, 2020

OK, I will merge this now. I realize that this is a bit forced, but having this hanging in a PR complicates related efforts substantially. The code should be organized in a way that its impact on existing functionality should be minimal. You can rightfully blame any fallout on me, and I promise to take care of it.

@mih mih merged commit 78591f6 into datalad:master Mar 8, 2020
11 of 18 checks passed
@mih mih deleted the rf-ria-to-core branch Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants