Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More crucial testing on Windows #4268

Merged
merged 4 commits into from Mar 9, 2020
Merged

More crucial testing on Windows #4268

merged 4 commits into from Mar 9, 2020

Conversation

mih
Copy link
Member

@mih mih commented Mar 9, 2020

No description provided.

@codecov
Copy link

@codecov codecov bot commented Mar 9, 2020

Codecov Report

No coverage uploaded for pull request base (master@d273b9e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4268   +/-   ##
=========================================
  Coverage          ?   88.71%           
=========================================
  Files             ?      282           
  Lines             ?    36928           
  Branches          ?        0           
=========================================
  Hits              ?    32759           
  Misses            ?     4169           
  Partials          ?        0
Impacted Files Coverage Δ
...ad/distributed/tests/test_create_sibling_gitlab.py 100% <ø> (ø)
datalad/local/tests/test_subdataset.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d273b9e...16b3ade. Read the comment docs.

@codecov
Copy link

@codecov codecov bot commented Mar 9, 2020

Codecov Report

Merging #4268 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4268      +/-   ##
==========================================
- Coverage   88.74%   88.71%   -0.04%     
==========================================
  Files         282      282              
  Lines       36920    36928       +8     
==========================================
- Hits        32765    32759       -6     
- Misses       4155     4169      +14     
Impacted Files Coverage Δ
...ad/distributed/tests/test_create_sibling_gitlab.py 100.00% <ø> (ø)
datalad/local/tests/test_subdataset.py 100.00% <100.00%> (ø)
datalad/support/annexrepo.py 85.54% <100.00%> (+0.13%) ⬆️
datalad/downloaders/http.py 72.11% <0.00%> (-2.79%) ⬇️
datalad/downloaders/tests/test_http.py 58.39% <0.00%> (-2.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d273b9e...16b3ade. Read the comment docs.

@mih
Copy link
Member Author

@mih mih commented Mar 9, 2020

Good on Windows, no worse elsewhere. Going in.

@mih mih merged commit 4e89de4 into datalad:master Mar 9, 2020
11 of 18 checks passed
@mih mih deleted the tst-win branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant