Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF: Factory function to get Repo instances from a path #4273

Merged
merged 1 commit into from Mar 10, 2020

Conversation

mih
Copy link
Member

@mih mih commented Mar 10, 2020

And RF Dataset.repo to use it.

This is needed for work in GitRepo, where type-specific prcoessing of
submodules is needed.

And RF Dataset.repo to use it.

This is needed for work in GitRepo, where type-specific prcoessing of
submodules is needed.
@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #4273 into master will increase coverage by 0.04%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4273      +/-   ##
==========================================
+ Coverage   88.71%   88.75%   +0.04%     
==========================================
  Files         282      283       +1     
  Lines       36928    36940      +12     
==========================================
+ Hits        32759    32787      +28     
+ Misses       4169     4153      -16     
Impacted Files Coverage Δ
datalad/core/local/repo.py 90.47% <90.47%> (ø)
datalad/distribution/dataset.py 96.23% <100.00%> (+0.66%) ⬆️
datalad/downloaders/tests/test_http.py 60.58% <0.00%> (+2.18%) ⬆️
datalad/downloaders/http.py 74.90% <0.00%> (+2.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e89de4...22df8bf. Read the comment docs.

@mih
Copy link
Member Author

mih commented Mar 10, 2020

This is a relatively simple, but useful change. Will merge now.

@mih mih merged commit ed0faaa into datalad:master Mar 10, 2020
11 of 18 checks passed
@mih mih deleted the nf-corerepo branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant