Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Run crippled FS tests with development version of git-annex #4276

Merged
merged 3 commits into from Mar 11, 2020

Conversation

mih
Copy link
Member

@mih mih commented Mar 10, 2020

No description provided.

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #4276 into master will decrease coverage by 0.90%.
The diff coverage is 81.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4276      +/-   ##
==========================================
- Coverage   89.66%   88.75%   -0.91%     
==========================================
  Files         275      283       +8     
  Lines       36860    36948      +88     
==========================================
- Hits        33049    32792     -257     
- Misses       3811     4156     +345     
Impacted Files Coverage Δ
datalad/config.py 96.54% <ø> (ø)
datalad/core/local/run.py 98.70% <ø> (ø)
datalad/core/local/save.py 98.68% <ø> (ø)
datalad/customremotes/tests/test_archives.py 89.54% <ø> (ø)
datalad/distributed/create_sibling_gitlab.py 74.67% <ø> (ø)
...ad/distributed/tests/test_create_sibling_gitlab.py 100.00% <ø> (ø)
datalad/distribution/create_sibling_github.py 83.60% <ø> (ø)
datalad/distribution/drop.py 98.79% <ø> (ø)
datalad/distribution/get.py 88.78% <ø> (ø)
datalad/distribution/install.py 98.87% <ø> (ø)
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d05e3...fb09071. Read the comment docs.

@mih
Copy link
Member Author

mih commented Mar 11, 2020

Almost there:

FAILED (SKIP=8, errors=1, failures=2)

@mih mih merged commit b2a79de into datalad:master Mar 11, 2020
10 of 18 checks passed
@mih mih deleted the tst-crippleddevel branch Mar 11, 2020
kyleam added a commit that referenced this issue Mar 12, 2020
b95bff1 (TST: Robustify tests for non-windows crippled FS,
2020-03-10) changed this condition from `not on_windows` to
`ds.repo.is_managed_branch()`.  This was merged in with gh-4276, but
as mentioned in review of gh-4275 [0], it seems very likely that a
`not` was unintentionally dropped, because it'd be strange to switch
from "not windows" to "ok managed branch, including windows" and
because the test now fails on the CrippledFS and Win2019 builds [1].

[0]: #4275 (comment)
[1]: https://github.com/datalad/datalad/runs/498868341#step:8:217
     https://github.com/datalad/datalad/runs/500836364?check_suite_focus=true#step:8:304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant