Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The great testing experience #4303

Merged
merged 3 commits into from Mar 15, 2020
Merged

The great testing experience #4303

merged 3 commits into from Mar 15, 2020

Conversation

mih
Copy link
Member

@mih mih commented Mar 15, 2020

  • abandon GitHub windows CI (what fails there has little chance to fail on a real system) fixes #4302
  • bring tests on crippled FS into the clear

In a parallel effort, I am running a full test sweep on real windows. I will close all current test failure issues on windows, unless they replicate on a real box. The beast died again... needs to wait until accessible.

@mih mih changed the title TMP The great testing experience Mar 15, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 15, 2020

Codecov Report

Merging #4303 into master will increase coverage by 0.04%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4303      +/-   ##
==========================================
+ Coverage   88.82%   88.86%   +0.04%     
==========================================
  Files         285      285              
  Lines       37443    37448       +5     
==========================================
+ Hits        33260    33280      +20     
+ Misses       4183     4168      -15
Impacted Files Coverage Δ
datalad/core/local/tests/test_run.py 98.68% <100%> (ø) ⬆️
datalad/core/distributed/tests/test_clone.py 92.32% <83.33%> (-0.16%) ⬇️
datalad/downloaders/tests/test_http.py 60.58% <0%> (+2.18%) ⬆️
datalad/downloaders/http.py 74.9% <0%> (+2.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6efb8dd...6de7dd6. Read the comment docs.

@mih mih marked this pull request as ready for review Mar 15, 2020
@mih mih merged commit 9e97094 into datalad:master Mar 15, 2020
11 of 12 checks passed
@mih mih deleted the tst-winless branch Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant