Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Expand testing on crippled FS to all modern API #4305

Merged
merged 3 commits into from Mar 15, 2020

Conversation

mih
Copy link
Member

@mih mih commented Mar 15, 2020

  • datalad.local.tests.test_subdataset.test_get_subdatasets protects against windows limitation, but it really is a file system limitation (trailing dot in filename)
  • datalad.distributed.tests.test_ria_data_transfer.test_binary_data_local internally invokes drop which is broken on crippled FS

@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #4305 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4305      +/-   ##
==========================================
- Coverage   88.84%   88.82%   -0.03%     
==========================================
  Files         285      285              
  Lines       37448    37451       +3     
==========================================
- Hits        33271    33265       -6     
- Misses       4177     4186       +9
Impacted Files Coverage Δ
datalad/local/tests/test_subdataset.py 100% <100%> (ø) ⬆️
...atalad/distributed/tests/test_ria_data_transfer.py 67.74% <33.33%> (-3.69%) ⬇️
datalad/downloaders/http.py 72.11% <0%> (-2.79%) ⬇️
datalad/downloaders/tests/test_http.py 58.39% <0%> (-2.19%) ⬇️
datalad/support/tests/test_annexrepo.py 95.27% <0%> (+0.4%) ⬆️
datalad/core/local/tests/test_save.py 96.75% <0%> (+0.49%) ⬆️
datalad/interface/tests/test_unlock.py 97.82% <0%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e97094...7641882. Read the comment docs.

mih added 2 commits Mar 15, 2020
I don't think it is worth building a complex corner case detection, the
spirit of the test is maintained without trailing dot, too.
@mih mih merged commit ac61a1d into datalad:master Mar 15, 2020
10 of 12 checks passed
@mih mih deleted the tst-morecrippled branch Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant