Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: examples of cloning specific ds versions from RIA stores #4314

Merged
merged 1 commit into from Mar 18, 2020

Conversation

adswa
Copy link
Member

@adswa adswa commented Mar 17, 2020

fixes #4313

@adswa
Copy link
Member Author

adswa commented Mar 17, 2020

(FTR: I have cancelled all tests where I found a cancel button apart from Docs)

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #4314 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4314      +/-   ##
==========================================
+ Coverage   88.83%   88.87%   +0.04%     
==========================================
  Files         285      285              
  Lines       37457    37457              
==========================================
+ Hits        33275    33291      +16     
+ Misses       4182     4166      -16     
Impacted Files Coverage Δ
datalad/core/distributed/clone.py 91.86% <ø> (ø)
datalad/downloaders/tests/test_http.py 60.96% <0.00%> (+2.16%) ⬆️
datalad/downloaders/http.py 74.90% <0.00%> (+2.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a727c...d50105c. Read the comment docs.

mih
mih approved these changes Mar 17, 2020
Copy link
Member

@mih mih left a comment

Thx! Personally, I would collapse the two examples into one and state that the identifier could be a branch or tag or shasum. Otherwise help gets longer without adding much additionsk info. But I am also OK with this state.

@adswa
Copy link
Member Author

adswa commented Mar 17, 2020

Will do (tomorrow). :)

@adswa
Copy link
Member Author

adswa commented Mar 18, 2020

Done

@kyleam kyleam merged commit 879e7e7 into datalad:master Mar 18, 2020
6 of 12 checks passed
@adswa adswa deleted the doc-clone branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants