Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common_cfg: Tweak log.outputs entry #4317

Merged
merged 2 commits into from Mar 19, 2020
Merged

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented Mar 18, 2020

The description for datalad.log.outputs says that the output is logged at DEBUG, which isn't the case. Fix that and make a few other minor changes.

kyleam added 2 commits Mar 18, 2020
This doesn't matter for how we access them (getbool), but it's
consistent with many other entries and serves as documentation.
When this option was initially added in 755d5f3 (ENH: log.outputs
config setting to trigger logging of the stdout/stderr [...],
2016-10-07), it was mostly true: stdout was logged at DEBUG, but
stderr was logged at DEBUG _or higher_, depending on the value of
expect_stderr/expect_fail.  As of 5d903d7 (RF: Switch Runner's log
levels from ERROR and DEBUG to 11 and 9 respectively [...],
2017-10-05), stdout is logged at level 9 and stderr at level 9 or 11.

Instead of trying to keep this up to date, instead give a floor
logging level that should be sufficient to see the output and is
unlikely to become stale.  Use 5 because this is the level that the
WitlessRunner logs at.

While here, update the title text to make it clearer that this is a
boolean thing.
@codecov
Copy link

@codecov codecov bot commented Mar 18, 2020

Codecov Report

Merging #4317 into maint will increase coverage by 47.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            maint    #4317       +/-   ##
===========================================
+ Coverage   42.58%   89.62%   +47.04%     
===========================================
  Files         275      275               
  Lines       36872    36872               
===========================================
+ Hits        15701    33046    +17345     
+ Misses      21171     3826    -17345     
Impacted Files Coverage Δ
datalad/interface/common_cfg.py 100.00% <ø> (ø)
datalad/core/local/create.py 94.73% <0.00%> (+0.75%) ⬆️
datalad/core/local/tests/test_create.py 100.00% <0.00%> (+0.90%) ⬆️
datalad/ui/progressbars.py 83.10% <0.00%> (+1.35%) ⬆️
datalad/support/external_versions.py 95.62% <0.00%> (+1.45%) ⬆️
datalad/dochelpers.py 87.40% <0.00%> (+1.48%) ⬆️
datalad/support/tests/test_network.py 100.00% <0.00%> (+1.83%) ⬆️
datalad/core/local/status.py 98.03% <0.00%> (+1.96%) ⬆️
datalad/support/tests/test_external_versions.py 91.94% <0.00%> (+2.01%) ⬆️
datalad/support/json_py.py 98.85% <0.00%> (+2.29%) ⬆️
... and 186 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ba7fb7...f6bcda9. Read the comment docs.

mih
mih approved these changes Mar 19, 2020
Copy link
Member

@mih mih left a comment

LGTM.Thx!

@mih mih merged commit c31dd05 into datalad:maint Mar 19, 2020
11 of 17 checks passed
@kyleam kyleam deleted the cfg-log-outputs branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants