Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Warn when provided dataset to wtf does not exist #4331

Merged
merged 1 commit into from Mar 24, 2020

Conversation

adswa
Copy link
Member

@adswa adswa commented Mar 24, 2020

it now says:

 datalad wtf -d ../nada                                                                       1 ↵
[WARNING] No dataset found at /tmp/nada. Reporting on the dataset is not attempted. [wtf(/tmp/nada)] 
# WTF
# WTF
## configuration <SENSITIVE, report disabled by configuration>
## datalad 
  - full_version: 0.12.3.dev547-g6a60c
  - version: 0.12.3.dev547
## dependencies 

fixes #4100

@mih mih added the UX label Mar 24, 2020
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #4331 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4331   +/-   ##
=======================================
  Coverage   88.85%   88.85%           
=======================================
  Files         285      285           
  Lines       37491    37492    +1     
=======================================
+ Hits        33313    33314    +1     
  Misses       4178     4178           
Impacted Files Coverage Δ
datalad/plugin/wtf.py 82.27% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bb9866...6a60cc2. Read the comment docs.

mih
mih approved these changes Mar 24, 2020
Copy link
Member

@mih mih left a comment

I think this is good. Thx!

@kyleam kyleam merged commit c1485d7 into datalad:master Mar 24, 2020
6 of 10 checks passed
@yarikoptic
Copy link
Member

yarikoptic commented Mar 24, 2020

Wouldn't this be worthwhile for maint?

@adswa
Copy link
Member Author

adswa commented Mar 24, 2020

Can we revert merging this? I just spotted in #4338 that it broke a test

@kyleam
Copy link
Collaborator

kyleam commented Mar 24, 2020

Can we revert merging this? I just spotted in #4338 that it broke a test

Oh my, I'm sorry. I thought I checked for failures, but I guess I overlooked this. This is my fault, so let me look into fixing it on top, but if for some reason that's not quick/easy, then I'd say we should revert.

@adswa
Copy link
Member Author

adswa commented Mar 24, 2020

nah, my fault (but I'm also fine blaming @mih) -- I bet I force-pushed a final change to hastily. Stupidly, that test is skipped when I run it locally.

kyleam added a commit to kyleam/datalad that referenced this issue Mar 24, 2020
I merged 6a60cc2 (ENH: Warn when provided dataset to wtf does not
exist, 2020-03-24) without doing a proper check of which tests failed.
Do the minimum fix to get it in a passing state.
@kyleam
Copy link
Collaborator

kyleam commented Mar 24, 2020

Hopefully resolved with gh-4339.

@kyleam
Copy link
Collaborator

kyleam commented Mar 24, 2020

Wouldn't this be worthwhile for maint?

I'm okay with this change only being in master.

@adswa
Copy link
Member Author

adswa commented Mar 24, 2020

thanks @kyleam!

@adswa adswa deleted the ux-4100 branch Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants