New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Warn when provided dataset to wtf does not exist #4331
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4331 +/- ##
=======================================
Coverage 88.85% 88.85%
=======================================
Files 285 285
Lines 37491 37492 +1
=======================================
+ Hits 33313 33314 +1
Misses 4178 4178
Continue to review full report at Codecov.
|
Wouldn't this be worthwhile for |
Can we revert merging this? I just spotted in #4338 that it broke a test |
Oh my, I'm sorry. I thought I checked for failures, but I guess I overlooked this. This is my fault, so let me look into fixing it on top, but if for some reason that's not quick/easy, then I'd say we should revert. |
nah, my fault (but I'm also fine blaming @mih) -- I bet I force-pushed a final change to hastily. Stupidly, that test is skipped when I run it locally. |
I merged 6a60cc2 (ENH: Warn when provided dataset to wtf does not exist, 2020-03-24) without doing a proper check of which tests failed. Do the minimum fix to get it in a passing state.
Hopefully resolved with gh-4339. |
I'm okay with this change only being in master. |
thanks @kyleam! |
it now says:
fixes #4100