Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Avoid spurious backslashes in manpage double-dash option listings #4332

Merged
merged 1 commit into from Mar 24, 2020

Conversation

mih
Copy link
Member

@mih mih commented Mar 24, 2020

They were introduced to avoid rendering of typographic m-dashes instead
of double-dashes in the HTML version. This change limits this escaping
to the HTML version.

Fixes gh-4032

They were introduced to avoid rendering of typographic m-dashes instead
of double-dashes in the HTML version. This change limits this escaping
to the HTML version.

Fixes dataladgh-4032

[ci skip]
@mih mih added documentation UX labels Mar 24, 2020
@kyleam kyleam merged commit 22cfcb7 into datalad:master Mar 24, 2020
8 of 9 checks passed
@yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Mar 24, 2020

shouldn't this be against maint?

$> git grep 'for p in parts)'
_datalad_build_support/formatters.py:            return ', '.join(p.replace('--', '-\\\\-') for p in parts)

$> git describe
0.12.4-9-gcc7e62771

@kyleam
Copy link
Contributor

@kyleam kyleam commented Mar 24, 2020

In my view a cosmetic fix like this is fine to be master only.

@mih mih deleted the bf-4032 branch Mar 24, 2020
@mih
Copy link
Member Author

@mih mih commented Mar 24, 2020

In my view a cosmetic fix like this is fine to be master only.

I agree, but also wouldn't object if someone picks it up in maint. I admit that the choice of master wasn't a conscious one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-to-maint documentation UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants