Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: tree-wide: Avoid use of deprecated get_submodules(compat=True) #4348

Merged
merged 1 commit into from Mar 26, 2020

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented Mar 25, 2020

bea8551 (RF: gitrepo: Rewrite get_submodules() to avoid GitPython,
2019-07-30) switched get_submodules() over to using the recently added
get_submodules_() method, adding a compat parameter to
get_submodules() that is true by default and leads to a return value
that mimics the old GitPython-based one for backward-compatibility.

That commit left a good number of spots in our internal code base
using the deprecated interface. Clean up all remaining uses of
get_submodules(..., compat=True).

bea8551 (RF: gitrepo: Rewrite get_submodules() to avoid GitPython,
2019-07-30) switched get_submodules() over to using the recently added
get_submodules_() method, adding a `compat` parameter to
get_submodules() that is true by default and leads to a return value
that mimics the old GitPython-based one for backward-compatibility.

That commit left a good number of spots in our internal code base
using the deprecated interface.  Clean up all remaining uses of
get_submodules(..., compat=True).
@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #4348 into master will increase coverage by 39.03%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4348       +/-   ##
===========================================
+ Coverage   49.76%   88.79%   +39.03%     
===========================================
  Files         285      285               
  Lines       37557    37557               
===========================================
+ Hits        18689    33349    +14660     
+ Misses      18868     4208    -14660     
Impacted Files Coverage Δ
datalad/tests/test_direct_mode.py 48.78% <0.00%> (+48.78%) ⬆️
datalad/interface/ls_webui.py 94.54% <100.00%> (+30.30%) ⬆️
datalad/support/gitrepo.py 90.00% <100.00%> (+13.62%) ⬆️
datalad/support/tests/test_annexrepo.py 95.32% <100.00%> (+93.26%) ⬆️
datalad/support/tests/test_gitrepo.py 99.75% <100.00%> (+97.56%) ⬆️
datalad/core/local/tests/test_create.py 100.00% <0.00%> (+0.44%) ⬆️
datalad/core/local/create.py 93.00% <0.00%> (+0.69%) ⬆️
datalad/local/subdatasets.py 95.65% <0.00%> (+0.86%) ⬆️
datalad/core/local/diff.py 95.34% <0.00%> (+1.16%) ⬆️
datalad/support/external_versions.py 95.62% <0.00%> (+1.45%) ⬆️
... and 177 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938d820...5b435bc. Read the comment docs.

mih
mih approved these changes Mar 26, 2020
Copy link
Member

@mih mih left a comment

Good catch. Thx!

@mih mih merged commit 6b28f4b into datalad:master Mar 26, 2020
12 checks passed
@kyleam kyleam deleted the get-submodules-no-compat-use branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants