Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Actually decode JSON #4361

Merged
merged 1 commit into from Mar 30, 2020
Merged

BF: Actually decode JSON #4361

merged 1 commit into from Mar 30, 2020

Conversation

bpoldrack
Copy link
Member

@bpoldrack bpoldrack commented Mar 30, 2020

Fixes #4360

I think once discovered this is quite obvious, but you changed that line last, @kyleam, so you might want to have a quick look.

instead of just returning a string in case of a last line without line ending (Closes datalad#4360)
@bpoldrack bpoldrack changed the base branch from master to maint Mar 30, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 30, 2020

Codecov Report

Merging #4361 into maint will decrease coverage by 45.29%.
The diff coverage is 34.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##            maint    #4361      +/-   ##
==========================================
- Coverage   89.43%   44.14%   -45.3%     
==========================================
  Files         275      285      +10     
  Lines       36931    37605     +674     
==========================================
- Hits        33031    16600   -16431     
- Misses       3900    21005   +17105
Impacted Files Coverage Δ
datalad/tests/test_utils.py 13.02% <ø> (-83.23%) ⬇️
datalad/tests/test_misc.py 35% <ø> (-65%) ⬇️
datalad/support/tests/test_json_py.py 28.57% <ø> (-71.43%) ⬇️
datalad/support/repo.py 85.1% <ø> (-10.64%) ⬇️
datalad/support/tests/test_network.py 12.45% <ø> (-87.55%) ⬇️
datalad/support/network.py 60.13% <ø> (-26.5%) ⬇️
datalad/tests/utils.py 60.14% <ø> (-29.71%) ⬇️
datalad/distribution/get.py 80.71% <ø> (-8.08%) ⬇️
datalad/tests/test_direct_mode.py 19.51% <ø> (-41.6%) ⬇️
datalad/support/tests/test_versions.py 21.05% <ø> (-78.95%) ⬇️
... and 385 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841480c...89a926b. Read the comment docs.

kyleam
kyleam approved these changes Mar 30, 2020
Copy link
Contributor

@kyleam kyleam left a comment

Guh, that was dumb of me. Thanks for noticing my mistake.

@kyleam kyleam merged commit 240cd63 into datalad:maint Mar 30, 2020
5 of 14 checks passed
@bpoldrack bpoldrack deleted the bf-load-json-stream branch Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants