RF: <Dataset path=...> -> <Dataset ...>

[mih]

repr of a dataset always uses the 'path=' prefix to the path, but a
dataset is also always and only identified by a path. Hence the prefix
is superfluous, and only takes space. On any platform an absolute path
is easy to recognize as such.

This change removes the 'path=' prefix.

[kyleam]

Makes sense to me.

[yarikoptic]

YES, PLEASE! ;) I always hated it but was too shy to suggest stripping it away -- one pros will be that you could just double click on the path to select it in the terminal, where now it would also grab path= prefix

[yarikoptic]

so, not a single unittest tested our repr for datasets? hm...

[kyleam]

one pros will be that you could just double click on the path to select it in the terminal

I'm looking forward to that too :) In the debugger, I often type <dataset>.path so that I can get something I can double-click on.

[kyleam]

I'd be happy to see this change land as is, but even better to my eyes would be a format like Dataset('/path/to/ds'), which I probably prefer just because it is a more common format for __repr__s.

[codecov]

Codecov Report

Merging #4420 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4420   +/-   ##
=======================================
  Coverage   88.91%   88.92%           
=======================================
  Files         285      285           
  Lines       37765    37802   +37     
=======================================
+ Hits        33578    33614   +36     
- Misses       4187     4188    +1     

Impacted Files	Coverage Δ
datalad/distribution/dataset.py	94.14% <100.00%> (ø)
datalad/support/tests/test_annexrepo.py	95.29% <0.00%> (-0.03%)	⬇️
datalad/interface/tests/test_utils.py	100.00% <0.00%> (ø)
datalad/interface/utils.py	94.11% <0.00%> (+0.02%)	⬆️
datalad/core/distributed/tests/test_clone.py	92.95% <0.00%> (+0.21%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d7683...226bee8. Read the comment docs.

[mih]

So what about this then (to really get to a C&P-able state that works for the cmdline and for Python):

>>> print('Dataset({})'.format(quote_cmdlinearg("/home/mih/this is fun/dataset")))       
Dataset('/home/mih/this is fun/dataset')

>>> print('Dataset({})'.format(quote_cmdlinearg("/home/mih/that's it folks/dataset")))   
Dataset('/home/mih/that'"'"'s it folks/dataset')

[kyleam]

Looks nice to me.

[yarikoptic]

Yes!

[mih]

Force-pushed this change.