Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Uniform __repr__ for Repo classes #4435

Merged
merged 1 commit into from Apr 22, 2020
Merged

Conversation

mih
Copy link
Member

@mih mih commented Apr 22, 2020

Continuing where 226bee8 stopped,
this compacts __repr__ for the Repo classes. Turning

<GitRepo path=/home/mih/hacking/datalad/git (<class 'datalad.support.gitrepo.GitRepo'>)>

into

GitRepo(/home/mih/hacking/datalad/git)

There is little (if any) practical benefit for reporing the class name.

Continuing where 226bee8 stopped,
this compacts __repr__ for the Repo classes. Turning

  `<GitRepo path=/home/mih/hacking/datalad/git (<class 'datalad.support.gitrepo.GitRepo'>)>`

into

  `GitRepo(/home/mih/hacking/datalad/git)`

There is little (if any) practical benefit for reporing the class name.
@codecov
Copy link

@codecov codecov bot commented Apr 22, 2020

Codecov Report

Merging #4435 into master will increase coverage by 39.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4435       +/-   ##
===========================================
+ Coverage   49.62%   88.88%   +39.25%     
===========================================
  Files         285      285               
  Lines       37814    37814               
===========================================
+ Hits        18766    33610    +14844     
+ Misses      19048     4204    -14844     
Impacted Files Coverage Δ
datalad/support/annexrepo.py 86.37% <100.00%> (+27.02%) ⬆️
datalad/support/gitrepo.py 89.96% <100.00%> (+14.63%) ⬆️
datalad/core/local/tests/test_create.py 100.00% <0.00%> (+0.44%) ⬆️
datalad/core/local/create.py 93.00% <0.00%> (+0.69%) ⬆️
datalad/local/subdatasets.py 95.65% <0.00%> (+0.86%) ⬆️
datalad/core/local/diff.py 95.34% <0.00%> (+1.16%) ⬆️
datalad/support/external_versions.py 95.62% <0.00%> (+1.45%) ⬆️
datalad/dochelpers.py 87.40% <0.00%> (+1.48%) ⬆️
datalad/support/tests/test_network.py 100.00% <0.00%> (+1.83%) ⬆️
datalad/interface/ls.py 62.60% <0.00%> (+1.98%) ⬆️
... and 174 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f9a67c...24f458c. Read the comment docs.

kyleam
kyleam approved these changes Apr 22, 2020
@adswa adswa merged commit 30e973e into datalad:master Apr 22, 2020
12 checks passed
@adswa adswa deleted the rf-reporepr branch Apr 22, 2020
@yarikoptic yarikoptic added this to the 0.13.0 milestone Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants